Skip to content

Commit

Permalink
staging: drm/imx: fix return value check in ipu_add_subdevice_pdata()
Browse files Browse the repository at this point in the history
In case of error, the function platform_device_register_data() returns
ERR_PTR() and never returns NULL. The NULL test in the return value check
should be replaced with IS_ERR().

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Wei Yongjun authored and Greg Kroah-Hartman committed Oct 30, 2013
1 parent 46a51c8 commit ed5d6ca
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/staging/imx-drm/ipu-v3/ipu-common.c
Original file line number Diff line number Diff line change
Expand Up @@ -1006,7 +1006,7 @@ static int ipu_add_subdevice_pdata(struct device *dev,
pdev = platform_device_register_data(dev, reg->name, ipu_client_id++,
&reg->pdata, sizeof(struct ipu_platform_reg));

return pdev ? 0 : -EINVAL;
return PTR_ERR_OR_ZERO(pdev);
}

static int ipu_add_client_devices(struct ipu_soc *ipu)
Expand Down

0 comments on commit ed5d6ca

Please sign in to comment.