Skip to content

Commit

Permalink
qlcnic: fix rcv buffer leak
Browse files Browse the repository at this point in the history
Rcv producer value should be read in spin-lock.

Signed-off-by: Amit Kumar Salecha <amit.salecha@qlogic.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Amit Kumar Salecha authored and David S. Miller committed Apr 22, 2010
1 parent ade91f8 commit ed6f135
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions drivers/net/qlcnic/qlcnic_init.c
Original file line number Diff line number Diff line change
Expand Up @@ -1554,9 +1554,10 @@ qlcnic_post_rx_buffers(struct qlcnic_adapter *adapter, u32 ringid,
int producer, count = 0;
struct list_head *head;

spin_lock(&rds_ring->lock);

producer = rds_ring->producer;

spin_lock(&rds_ring->lock);
head = &rds_ring->free_list;
while (!list_empty(head)) {

Expand All @@ -1578,13 +1579,13 @@ qlcnic_post_rx_buffers(struct qlcnic_adapter *adapter, u32 ringid,

producer = get_next_index(producer, rds_ring->num_desc);
}
spin_unlock(&rds_ring->lock);

if (count) {
rds_ring->producer = producer;
writel((producer-1) & (rds_ring->num_desc-1),
rds_ring->crb_rcv_producer);
}
spin_unlock(&rds_ring->lock);
}

static void
Expand All @@ -1596,10 +1597,11 @@ qlcnic_post_rx_buffers_nodb(struct qlcnic_adapter *adapter,
int producer, count = 0;
struct list_head *head;

producer = rds_ring->producer;
if (!spin_trylock(&rds_ring->lock))
return;

producer = rds_ring->producer;

head = &rds_ring->free_list;
while (!list_empty(head)) {

Expand Down

0 comments on commit ed6f135

Please sign in to comment.