Skip to content

Commit

Permalink
HID: wacom: make sysfs permissions more strict
Browse files Browse the repository at this point in the history
It's not really dangerous in this driver, but it's against general
practice and worth fixing.

Wacom uses the attribute for changing the reporting speed of the
tablet (and this actually requires poking the device in the
background) (still I wouldn't consider it a security issue though).

udev is a proper place to handle this.

Reported-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
  • Loading branch information
Jiri Kosina committed Nov 18, 2010
1 parent c311598 commit edd2126
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/hid/hid-wacom.c
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ static ssize_t wacom_store_speed(struct device *dev,
return -EINVAL;
}

static DEVICE_ATTR(speed, S_IRUGO | S_IWUGO,
static DEVICE_ATTR(speed, S_IRUGO | S_IWUSR | S_IWGRP,
wacom_show_speed, wacom_store_speed);

static int wacom_raw_event(struct hid_device *hdev, struct hid_report *report,
Expand Down

0 comments on commit edd2126

Please sign in to comment.