Skip to content

Commit

Permalink
[XFS] Fix xfs_lowbit64
Browse files Browse the repository at this point in the history
xfs_lowbit64 was broken on 32 bit platforms in a recent cleanup of the xfs
bitops. Fix it back up again.

SGI-PV: 974005
SGI-Modid: xfs-linux-melb:xfs-kern:30202a

Signed-off-by: David Chinner <dgc@sgi.com>
Signed-off-by: Lachlan McIlroy <lachlan@sgi.com>
  • Loading branch information
David Chinner authored and Lachlan McIlroy committed Feb 7, 2008
1 parent 45ba598 commit edd319d
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions fs/xfs/xfs_bit.h
Original file line number Diff line number Diff line change
Expand Up @@ -61,15 +61,15 @@ static inline int xfs_highbit64(__uint64_t v)
/* Get low bit set out of 32-bit argument, -1 if none set */
static inline int xfs_lowbit32(__uint32_t v)
{
unsigned long t = v;
return (v) ? find_first_bit(&t, 32) : -1;
__uint32_t t = v;
return (t) ? find_first_bit((unsigned long *)&t, 32) : -1;
}

/* Get low bit set out of 64-bit argument, -1 if none set */
static inline int xfs_lowbit64(__uint64_t v)
{
unsigned long t = v;
return (v) ? find_first_bit(&t, 64) : -1;
__uint64_t t = v;
return (t) ? find_first_bit((unsigned long *)&t, 64) : -1;
}

/* Return whether bitmap is empty (1 == empty) */
Expand Down

0 comments on commit edd319d

Please sign in to comment.