Skip to content

Commit

Permalink
[PATCH] count bounce buffer pages in vmstat
Browse files Browse the repository at this point in the history
This is a patch for counting the number of pages for bounce buffers.  It's
shown in /proc/vmstat.

Currently, the number of bounce pages are not counted anywhere.  So, if
there are many bounce pages, it seems that there are leaked pages.  And
it's difficult for a user to imagine the usage of bounce pages.  So, it's
meaningful to show # of bouce pages.

Signed-off-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
  • Loading branch information
KAMEZAWA Hiroyuki authored and Linus Torvalds committed May 1, 2005
1 parent 2054606 commit edfbe2b
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 0 deletions.
1 change: 1 addition & 0 deletions include/linux/page-flags.h
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,7 @@ struct page_state {
unsigned long allocstall; /* direct reclaim calls */

unsigned long pgrotated; /* pages rotated to tail of the LRU */
unsigned long nr_bounce; /* pages for bounce buffers */
};

extern void get_page_state(struct page_state *ret);
Expand Down
2 changes: 2 additions & 0 deletions mm/highmem.c
Original file line number Diff line number Diff line change
Expand Up @@ -325,6 +325,7 @@ static void bounce_end_io(struct bio *bio, mempool_t *pool, int err)
continue;

mempool_free(bvec->bv_page, pool);
dec_page_state(nr_bounce);
}

bio_endio(bio_orig, bio_orig->bi_size, err);
Expand Down Expand Up @@ -405,6 +406,7 @@ static void __blk_queue_bounce(request_queue_t *q, struct bio **bio_orig,
to->bv_page = mempool_alloc(pool, q->bounce_gfp);
to->bv_len = from->bv_len;
to->bv_offset = from->bv_offset;
inc_page_state(nr_bounce);

if (rw == WRITE) {
char *vto, *vfrom;
Expand Down
1 change: 1 addition & 0 deletions mm/page_alloc.c
Original file line number Diff line number Diff line change
Expand Up @@ -1897,6 +1897,7 @@ static char *vmstat_text[] = {
"allocstall",

"pgrotated",
"nr_bounce",
};

static void *vmstat_start(struct seq_file *m, loff_t *pos)
Expand Down

0 comments on commit edfbe2b

Please sign in to comment.