Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 124894
b: refs/heads/master
c: 26c5295
h: refs/heads/master
v: v3
  • Loading branch information
Dave Chinner authored and Niv Sardi committed Dec 1, 2008
1 parent 18d6ceb commit ee08ba3
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 39 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: 207fcfad58482c7c9f92939a1f6df9f7e8873a34
refs/heads/master: 26c5295135d10fc90cbf160adfda392d91f58279
1 change: 0 additions & 1 deletion trunk/fs/xfs/xfs_inode.h
Original file line number Diff line number Diff line change
Expand Up @@ -261,7 +261,6 @@ typedef struct xfs_inode {
unsigned short i_flags; /* see defined flags below */
unsigned char i_update_core; /* timestamps/size is dirty */
unsigned char i_update_size; /* di_size field is dirty */
unsigned int i_gen; /* generation count */
unsigned int i_delayed_blks; /* count of delay alloc blks */

xfs_icdinode_t i_d; /* most of ondisk inode */
Expand Down
12 changes: 2 additions & 10 deletions trunk/fs/xfs/xfs_rename.c
Original file line number Diff line number Diff line change
Expand Up @@ -367,19 +367,11 @@ xfs_rename(
&first_block, &free_list, spaceres);
if (error)
goto abort_return;
xfs_ichgtime(src_dp, XFS_ICHGTIME_MOD | XFS_ICHGTIME_CHG);

/*
* Update the generation counts on all the directory inodes
* that we're modifying.
*/
src_dp->i_gen++;
xfs_ichgtime(src_dp, XFS_ICHGTIME_MOD | XFS_ICHGTIME_CHG);
xfs_trans_log_inode(tp, src_dp, XFS_ILOG_CORE);

if (new_parent) {
target_dp->i_gen++;
if (new_parent)
xfs_trans_log_inode(tp, target_dp, XFS_ILOG_CORE);
}

/*
* If this is a synchronous mount, make sure that the
Expand Down
29 changes: 2 additions & 27 deletions trunk/fs/xfs/xfs_vnodeops.c
Original file line number Diff line number Diff line change
Expand Up @@ -1599,8 +1599,6 @@ xfs_create(
xfs_trans_set_sync(tp);
}

dp->i_gen++;

/*
* Attach the dquot(s) to the inodes and modify them incore.
* These ids of the inode couldn't have changed since the new
Expand Down Expand Up @@ -1967,13 +1965,6 @@ xfs_remove(
}
xfs_ichgtime(dp, XFS_ICHGTIME_MOD | XFS_ICHGTIME_CHG);

/*
* Bump the in memory generation count on the parent
* directory so that other can know that it has changed.
*/
dp->i_gen++;
xfs_trans_log_inode(tp, dp, XFS_ILOG_CORE);

if (is_dir) {
/*
* Drop the link from ip's "..".
Expand All @@ -1991,8 +1982,8 @@ xfs_remove(
} else {
/*
* When removing a non-directory we need to log the parent
* inode here for the i_gen update. For a directory this is
* done implicitly by the xfs_droplink call for the ".." entry.
* inode here. For a directory this is done implicitly
* by the xfs_droplink call for the ".." entry.
*/
xfs_trans_log_inode(tp, dp, XFS_ILOG_CORE);
}
Expand Down Expand Up @@ -2152,7 +2143,6 @@ xfs_link(
if (error)
goto abort_return;
xfs_ichgtime(tdp, XFS_ICHGTIME_MOD | XFS_ICHGTIME_CHG);
tdp->i_gen++;
xfs_trans_log_inode(tp, tdp, XFS_ILOG_CORE);

error = xfs_bumplink(tp, sip);
Expand Down Expand Up @@ -2329,18 +2319,10 @@ xfs_mkdir(
}
xfs_ichgtime(dp, XFS_ICHGTIME_MOD | XFS_ICHGTIME_CHG);

/*
* Bump the in memory version number of the parent directory
* so that other processes accessing it will recognize that
* the directory has changed.
*/
dp->i_gen++;

error = xfs_dir_init(tp, cdp, dp);
if (error)
goto error2;

cdp->i_gen = 1;
error = xfs_bumplink(tp, dp);
if (error)
goto error2;
Expand Down Expand Up @@ -2626,13 +2608,6 @@ xfs_symlink(
xfs_ichgtime(dp, XFS_ICHGTIME_MOD | XFS_ICHGTIME_CHG);
xfs_trans_log_inode(tp, dp, XFS_ILOG_CORE);

/*
* Bump the in memory version number of the parent directory
* so that other processes accessing it will recognize that
* the directory has changed.
*/
dp->i_gen++;

/*
* If this is a synchronous mount, make sure that the
* symlink transaction goes to disk before returning to
Expand Down

0 comments on commit ee08ba3

Please sign in to comment.