Skip to content

Commit

Permalink
ieee1394: Remove superfluous calls to kobject_set_name().
Browse files Browse the repository at this point in the history
Unless you're adding a kobject to the sysfs hierarchy, there is no
point setting its kobject name.

Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
  • Loading branch information
Robert P. J. Day authored and Stefan Richter committed Apr 18, 2008
1 parent 9508c20 commit ee2d91e
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 3 deletions.
1 change: 0 additions & 1 deletion drivers/ieee1394/dv1394.c
Original file line number Diff line number Diff line change
Expand Up @@ -2567,7 +2567,6 @@ static int __init dv1394_init_module(void)

cdev_init(&dv1394_cdev, &dv1394_fops);
dv1394_cdev.owner = THIS_MODULE;
kobject_set_name(&dv1394_cdev.kobj, "dv1394");
ret = cdev_add(&dv1394_cdev, IEEE1394_DV1394_DEV, 16);
if (ret) {
printk(KERN_ERR "dv1394: unable to register character device\n");
Expand Down
1 change: 0 additions & 1 deletion drivers/ieee1394/raw1394.c
Original file line number Diff line number Diff line change
Expand Up @@ -3003,7 +3003,6 @@ static int __init init_raw1394(void)

cdev_init(&raw1394_cdev, &raw1394_fops);
raw1394_cdev.owner = THIS_MODULE;
kobject_set_name(&raw1394_cdev.kobj, RAW1394_DEVICE_NAME);
ret = cdev_add(&raw1394_cdev, IEEE1394_RAW1394_DEV, 1);
if (ret) {
HPSB_ERR("raw1394 failed to register minor device block");
Expand Down
1 change: 0 additions & 1 deletion drivers/ieee1394/video1394.c
Original file line number Diff line number Diff line change
Expand Up @@ -1503,7 +1503,6 @@ static int __init video1394_init_module (void)

cdev_init(&video1394_cdev, &video1394_fops);
video1394_cdev.owner = THIS_MODULE;
kobject_set_name(&video1394_cdev.kobj, VIDEO1394_DRIVER_NAME);
ret = cdev_add(&video1394_cdev, IEEE1394_VIDEO1394_DEV, 16);
if (ret) {
PRINT_G(KERN_ERR, "video1394: unable to get minor device block");
Expand Down

0 comments on commit ee2d91e

Please sign in to comment.