Skip to content

Commit

Permalink
[ARM] fix AT91 include loops
Browse files Browse the repository at this point in the history
AT91 has one include loop in its header files:

  include/asm-arm/io.h <- include/asm-arm/arch-at91/io.h <-
   include/asm-arm/io.h

Circular include dependencies are dangerous since they can result in
inconsistent definitions being provided to other code, especially if
'#ifndef' constructs are used.

Solve this by removing the offending includes.  Built tested using my
AT91 configuration.

Acked-by: Andrew Victor <linux@maxim.org.za>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
  • Loading branch information
Russell King authored and Russell King committed Jun 1, 2008
1 parent 1beee8d commit ee48a75
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions include/asm-arm/arch-at91/io.h
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,6 @@
#ifndef __ASM_ARCH_IO_H
#define __ASM_ARCH_IO_H

#include <asm/io.h>

#define IO_SPACE_LIMIT 0xFFFFFFFF

#define __io(a) ((void __iomem *)(a))
Expand Down

0 comments on commit ee48a75

Please sign in to comment.