Skip to content

Commit

Permalink
netdev: Move next_sched into struct netdev_queue.
Browse files Browse the repository at this point in the history
We schedule queues, not the device, for output queue processing in BH.

Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
David S. Miller committed Jul 9, 2008
1 parent 74d58a0 commit ee609cb
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 11 deletions.
5 changes: 2 additions & 3 deletions include/linux/netdevice.h
Original file line number Diff line number Diff line change
Expand Up @@ -454,6 +454,7 @@ struct netdev_queue {
struct Qdisc *qdisc;
struct Qdisc *qdisc_sleeping;
struct list_head qdisc_list;
struct netdev_queue *next_sched;
};

/*
Expand Down Expand Up @@ -545,8 +546,6 @@ struct net_device
#define NETIF_F_V6_CSUM (NETIF_F_GEN_CSUM | NETIF_F_IPV6_CSUM)
#define NETIF_F_ALL_CSUM (NETIF_F_V4_CSUM | NETIF_F_V6_CSUM)

struct net_device *next_sched;

/* Interface index. Unique device identifier */
int ifindex;
int iflink;
Expand Down Expand Up @@ -940,7 +939,7 @@ static inline int unregister_gifconf(unsigned int family)
*/
struct softnet_data
{
struct net_device *output_queue;
struct netdev_queue *output_queue;
struct sk_buff_head input_pkt_queue;
struct list_head poll_list;
struct sk_buff *completion_queue;
Expand Down
15 changes: 7 additions & 8 deletions net/core/dev.c
Original file line number Diff line number Diff line change
Expand Up @@ -1323,13 +1323,14 @@ static void dev_queue_xmit_nit(struct sk_buff *skb, struct net_device *dev)
void __netif_schedule(struct net_device *dev)
{
if (!test_and_set_bit(__LINK_STATE_SCHED, &dev->state)) {
struct netdev_queue *txq = &dev->tx_queue;
unsigned long flags;
struct softnet_data *sd;

local_irq_save(flags);
sd = &__get_cpu_var(softnet_data);
dev->next_sched = sd->output_queue;
sd->output_queue = dev;
txq->next_sched = sd->output_queue;
sd->output_queue = txq;
raise_softirq_irqoff(NET_TX_SOFTIRQ);
local_irq_restore(flags);
}
Expand Down Expand Up @@ -1912,20 +1913,18 @@ static void net_tx_action(struct softirq_action *h)
}

if (sd->output_queue) {
struct net_device *head;
struct netdev_queue *head;

local_irq_disable();
head = sd->output_queue;
sd->output_queue = NULL;
local_irq_enable();

while (head) {
struct net_device *dev = head;
struct netdev_queue *txq;
struct netdev_queue *txq = head;
struct net_device *dev = txq->dev;
head = head->next_sched;

txq = &dev->tx_queue;

smp_mb__before_clear_bit();
clear_bit(__LINK_STATE_SCHED, &dev->state);

Expand Down Expand Up @@ -4346,7 +4345,7 @@ static int dev_cpu_callback(struct notifier_block *nfb,
void *ocpu)
{
struct sk_buff **list_skb;
struct net_device **list_net;
struct netdev_queue **list_net;
struct sk_buff *skb;
unsigned int cpu, oldcpu = (unsigned long)ocpu;
struct softnet_data *sd, *oldsd;
Expand Down

0 comments on commit ee609cb

Please sign in to comment.