Skip to content

Commit

Permalink
drm/i915: enable output polling during S4 thaw
Browse files Browse the repository at this point in the history
To avoid processing hotplug events we disable connector polling for the
duration of S3 suspend. We also disable it for S4 freeze, and keep it
disabled after S4 thaw. This won't prevent though hotplug processing,
since we re-enable interrupts anyway. There is also no need to prevent
it at that time, since we reinitialize everything during thaw, so the
device is in a consistent state. So to simplify things enable polling
during thaw, which will allow us to handle S4 thaw the same way as S3
resume in an upcoming patch.

Signed-off-by: Imre Deak <imre.deak@intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
  • Loading branch information
Imre Deak authored and Daniel Vetter committed Oct 24, 2014
1 parent ed49388 commit ee6f280
Showing 1 changed file with 3 additions and 8 deletions.
11 changes: 3 additions & 8 deletions drivers/gpu/drm/i915/i915_drv.c
Original file line number Diff line number Diff line change
Expand Up @@ -752,6 +752,8 @@ static int __i915_drm_thaw(struct drm_device *dev)

intel_opregion_notify_adapter(dev, PCI_D0);

drm_kms_helper_poll_enable(dev);

return 0;
}

Expand Down Expand Up @@ -781,14 +783,7 @@ static int i915_resume_early(struct drm_device *dev)

static int i915_drm_resume(struct drm_device *dev)
{
int ret;

ret = __i915_drm_thaw(dev);
if (ret)
return ret;

drm_kms_helper_poll_enable(dev);
return 0;
return __i915_drm_thaw(dev);
}

static int i915_resume_legacy(struct drm_device *dev)
Expand Down

0 comments on commit ee6f280

Please sign in to comment.