Skip to content

Commit

Permalink
Merge branch 'perf/core' of git://github.com/acmel/linux into perf/core
Browse files Browse the repository at this point in the history
  • Loading branch information
Ingo Molnar committed Oct 17, 2011
2 parents 53b0a61 + 7bc7298 commit ee8f967
Show file tree
Hide file tree
Showing 4 changed files with 22 additions and 10 deletions.
9 changes: 7 additions & 2 deletions tools/perf/builtin-top.c
Original file line number Diff line number Diff line change
Expand Up @@ -304,7 +304,9 @@ static void print_sym_table(void)

hists__collapse_resort_threaded(&top.sym_evsel->hists);
hists__output_resort_threaded(&top.sym_evsel->hists);
hists__decay_entries_threaded(&top.sym_evsel->hists);
hists__decay_entries_threaded(&top.sym_evsel->hists,
top.hide_user_symbols,
top.hide_kernel_symbols);
hists__output_recalc_col_len(&top.sym_evsel->hists, winsize.ws_row - 3);
putchar('\n');
hists__fprintf(&top.sym_evsel->hists, NULL, false, false,
Expand Down Expand Up @@ -436,6 +438,7 @@ static int key_mapped(int c)
case 'S':
return 1;
case 'E':
return top.evlist->nr_entries > 1 ? 1 : 0;
default:
break;
}
Expand Down Expand Up @@ -555,7 +558,9 @@ static void perf_top__sort_new_samples(void *arg)

hists__collapse_resort_threaded(&t->sym_evsel->hists);
hists__output_resort_threaded(&t->sym_evsel->hists);
hists__decay_entries_threaded(&t->sym_evsel->hists);
hists__decay_entries_threaded(&t->sym_evsel->hists,
top.hide_user_symbols,
top.hide_kernel_symbols);
hists__output_recalc_col_len(&t->sym_evsel->hists, winsize.ws_row - 3);
}

Expand Down
17 changes: 11 additions & 6 deletions tools/perf/util/hist.c
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,8 @@ static bool hists__decay_entry(struct hists *hists, struct hist_entry *he)
return he->period == 0;
}

static void __hists__decay_entries(struct hists *hists, bool threaded)
static void __hists__decay_entries(struct hists *hists, bool zap_user,
bool zap_kernel, bool threaded)
{
struct rb_node *next = rb_first(&hists->entries);
struct hist_entry *n;
Expand All @@ -121,7 +122,10 @@ static void __hists__decay_entries(struct hists *hists, bool threaded)
* case some it gets new samples, we'll eventually free it when
* the user stops browsing and it agains gets fully decayed.
*/
if (hists__decay_entry(hists, n) && !n->used) {
if (((zap_user && n->level == '.') ||
(zap_kernel && n->level != '.') ||
hists__decay_entry(hists, n)) &&
!n->used) {
rb_erase(&n->rb_node, &hists->entries);

if (sort__need_collapse || threaded)
Expand All @@ -133,14 +137,15 @@ static void __hists__decay_entries(struct hists *hists, bool threaded)
}
}

void hists__decay_entries(struct hists *hists)
void hists__decay_entries(struct hists *hists, bool zap_user, bool zap_kernel)
{
return __hists__decay_entries(hists, false);
return __hists__decay_entries(hists, zap_user, zap_kernel, false);
}

void hists__decay_entries_threaded(struct hists *hists)
void hists__decay_entries_threaded(struct hists *hists,
bool zap_user, bool zap_kernel)
{
return __hists__decay_entries(hists, true);
return __hists__decay_entries(hists, zap_user, zap_kernel, true);
}

/*
Expand Down
5 changes: 3 additions & 2 deletions tools/perf/util/hist.h
Original file line number Diff line number Diff line change
Expand Up @@ -78,8 +78,9 @@ void hists__output_resort_threaded(struct hists *hists);
void hists__collapse_resort(struct hists *self);
void hists__collapse_resort_threaded(struct hists *hists);

void hists__decay_entries(struct hists *hists);
void hists__decay_entries_threaded(struct hists *hists);
void hists__decay_entries(struct hists *hists, bool zap_user, bool zap_kernel);
void hists__decay_entries_threaded(struct hists *hists, bool zap_user,
bool zap_kernel);
void hists__output_recalc_col_len(struct hists *hists, int max_rows);

void hists__inc_nr_events(struct hists *self, u32 type);
Expand Down
1 change: 1 addition & 0 deletions tools/perf/util/ui/helpline.h
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
#define _PERF_UI_HELPLINE_H_ 1

#include <stdio.h>
#include <stdarg.h>

void ui_helpline__init(void);
void ui_helpline__pop(void);
Expand Down

0 comments on commit ee8f967

Please sign in to comment.