Skip to content

Commit

Permalink
ARM: mxs: retrieve timer irq from device tree
Browse files Browse the repository at this point in the history
Rather than using the static timer irq definition, we should retrieve
timer irq from device tree for better.

Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
  • Loading branch information
Shawn Guo committed Sep 3, 2012
1 parent 0b76c54 commit eeca6e6
Show file tree
Hide file tree
Showing 6 changed files with 19 additions and 6 deletions.
3 changes: 2 additions & 1 deletion arch/arm/boot/dts/imx23.dtsi
Original file line number Diff line number Diff line change
Expand Up @@ -389,8 +389,9 @@
};

timrot@80068000 {
compatible = "fsl,imx23-timrot", "fsl,timrot";
reg = <0x80068000 0x2000>;
status = "disabled";
interrupts = <28 29 30 31>;
};

auart0: serial@8006c000 {
Expand Down
3 changes: 2 additions & 1 deletion arch/arm/boot/dts/imx28.dtsi
Original file line number Diff line number Diff line change
Expand Up @@ -683,8 +683,9 @@
};

timrot@80068000 {
compatible = "fsl,imx28-timrot", "fsl,timrot";
reg = <0x80068000 0x2000>;
status = "disabled";
interrupts = <48 49 50 51>;
};

auart0: serial@8006a000 {
Expand Down
2 changes: 1 addition & 1 deletion arch/arm/mach-mxs/include/mach/common.h
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@

extern const u32 *mxs_get_ocotp(void);
extern int mxs_reset_block(void __iomem *);
extern void mxs_timer_init(int);
extern void mxs_timer_init(void);
extern void mxs_restart(char, const char *);
extern int mxs_saif_clkmux_select(unsigned int clkmux);

Expand Down
13 changes: 12 additions & 1 deletion arch/arm/mach-mxs/timer.c
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@
#include <linux/irq.h>
#include <linux/clockchips.h>
#include <linux/clk.h>
#include <linux/of.h>
#include <linux/of_irq.h>

#include <asm/mach/time.h>
#include <mach/mxs.h>
Expand Down Expand Up @@ -244,9 +246,17 @@ static int __init mxs_clocksource_init(struct clk *timer_clk)
return 0;
}

void __init mxs_timer_init(int irq)
void __init mxs_timer_init(void)
{
struct device_node *np;
struct clk *timer_clk;
int irq;

np = of_find_compatible_node(NULL, NULL, "fsl,timrot");
if (!np) {
pr_err("%s: failed find timrot node\n", __func__);
return;
}

timer_clk = clk_get_sys("timrot", NULL);
if (IS_ERR(timer_clk)) {
Expand Down Expand Up @@ -295,5 +305,6 @@ void __init mxs_timer_init(int irq)
mxs_clockevent_init(timer_clk);

/* Make irqs happen */
irq = irq_of_parse_and_map(np, 0);
setup_irq(irq, &mxs_timer_irq);
}
2 changes: 1 addition & 1 deletion drivers/clk/mxs/clk-imx23.c
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,7 @@ int __init mx23_clocks_init(void)
for (i = 0; i < ARRAY_SIZE(clks_init_on); i++)
clk_prepare_enable(clks[clks_init_on[i]]);

mxs_timer_init(MX23_INT_TIMER0);
mxs_timer_init();

return 0;
}
2 changes: 1 addition & 1 deletion drivers/clk/mxs/clk-imx28.c
Original file line number Diff line number Diff line change
Expand Up @@ -337,7 +337,7 @@ int __init mx28_clocks_init(void)
for (i = 0; i < ARRAY_SIZE(clks_init_on); i++)
clk_prepare_enable(clks[clks_init_on[i]]);

mxs_timer_init(MX28_INT_TIMER0);
mxs_timer_init();

return 0;
}

0 comments on commit eeca6e6

Please sign in to comment.