Skip to content

Commit

Permalink
V4L/DVB (6897): xc2028: ignore HAS_IF during specific S-Code type sea…
Browse files Browse the repository at this point in the history
…rches

If we are selecting the S-Code firmware to load by name, then we must mask
off the HAS_IF bit during the search.

Signed-off-by: Chris Pascoe <c.pascoe@itee.uq.edu.au>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
  • Loading branch information
Chris Pascoe authored and Mauro Carvalho Chehab committed Jan 25, 2008
1 parent 0e614cd commit ef207fe
Showing 1 changed file with 7 additions and 4 deletions.
11 changes: 7 additions & 4 deletions drivers/media/video/tuner-xc2028.c
Original file line number Diff line number Diff line change
Expand Up @@ -395,6 +395,7 @@ static int seek_firmware(struct dvb_frontend *fe, unsigned int type,
{
struct xc2028_data *priv = fe->tuner_priv;
int i, best_i = -1, best_nr_matches = 0;
unsigned int ign_firm_type_mask = 0;

tuner_dbg("%s called, want type=", __FUNCTION__);
if (debug) {
Expand All @@ -412,16 +413,18 @@ static int seek_firmware(struct dvb_frontend *fe, unsigned int type,

if (type & BASE)
type &= BASE_TYPES;
else if (type & SCODE)
else if (type & SCODE) {
type &= SCODE_TYPES;
else if (type & DTV_TYPES)
ign_firm_type_mask = HAS_IF;
} else if (type & DTV_TYPES)
type &= DTV_TYPES;
else if (type & STD_SPECIFIC_TYPES)
type &= STD_SPECIFIC_TYPES;

/* Seek for exact match */
for (i = 0; i < priv->firm_size; i++) {
if ((type == priv->firm[i].type) && (*id == priv->firm[i].id))
if ((type == (priv->firm[i].type & ~ign_firm_type_mask)) &&
(*id == priv->firm[i].id))
goto found;
}

Expand All @@ -430,7 +433,7 @@ static int seek_firmware(struct dvb_frontend *fe, unsigned int type,
v4l2_std_id match_mask;
int nr_matches;

if (type != priv->firm[i].type)
if (type != (priv->firm[i].type & ~ign_firm_type_mask))
continue;

match_mask = *id & priv->firm[i].id;
Expand Down

0 comments on commit ef207fe

Please sign in to comment.