Skip to content

Commit

Permalink
[media] saa7164: Remove pointless conditional and save a few bytes in…
Browse files Browse the repository at this point in the history
… saa7164_downloadfirmware()

Hi,

release_firmware() just does nothing if passed a NULL pointer. So there's
no reason to test before the call in
saa7164-fw.c::saa7164_downloadfirmware().

Removing the pointless conditional also saves a few bytes.
before:
   text    data     bss     dec     hex filename
   7943     112    2144   10199    27d7 drivers/media/video/saa7164/saa7164-fw.o
after:
   text    data     bss     dec     hex filename
   7931     112    2136   10179    27c3 drivers/media/video/saa7164/saa7164-fw.o

Signed-off-by: Jesper Juhl <jj@chaosbits.net>
Cc: Steven Toth <stoth@kernellabs.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
  • Loading branch information
Jesper Juhl authored and Mauro Carvalho Chehab committed Dec 29, 2010
1 parent 10304ca commit ef330dc
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions drivers/media/video/saa7164/saa7164-fw.c
Original file line number Diff line number Diff line change
Expand Up @@ -608,8 +608,6 @@ int saa7164_downloadfirmware(struct saa7164_dev *dev)
ret = 0;

out:
if (fw)
release_firmware(fw);

release_firmware(fw);
return ret;
}

0 comments on commit ef330dc

Please sign in to comment.