Skip to content

Commit

Permalink
staging: comedi: addi_apci_2032: only disable triggered interrupts
Browse files Browse the repository at this point in the history
The interrupt handler disables all interrupt sources when a valid
interrupt occurs.  Just disable the triggered interrupt source so we can
still get interrupts for the other interrupt source.

Also add a comment indicating why the triggered interrupt source is
disabled.  The interrupt sources are level-sensitive and indicate
hardware errors that are likely to be persistent, so if we reenabled
them they would just keep triggering repeatedly.

Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Ian Abbott authored and Greg Kroah-Hartman committed Jan 7, 2013
1 parent b652bd8 commit ef6543d
Showing 1 changed file with 7 additions and 1 deletion.
8 changes: 7 additions & 1 deletion drivers/staging/comedi/drivers/addi_apci_2032.c
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,13 @@ static irqreturn_t apci2032_interrupt(int irq, void *d)
return IRQ_NONE;

val = inl(dev->iobase + APCI2032_INT_STATUS_REG) & 3;
outl(0x00, dev->iobase + APCI2032_INT_CTRL_REG);
/* Disable triggered interrupt sources. */
outl(~val & 3, dev->iobase + APCI2032_INT_CTRL_REG);
/*
* Note: We don't reenable the triggered interrupt sources because they
* are level-sensitive, hardware error status interrupt sources and
* they'd keep triggering interrupts repeatedly.
*/

if (comedi_buf_put(s->async, val))
s->async->events |= COMEDI_CB_BLOCK | COMEDI_CB_EOS;
Expand Down

0 comments on commit ef6543d

Please sign in to comment.