Skip to content

Commit

Permalink
Documentation: kbuild: Improve if_changed documentation
Browse files Browse the repository at this point in the history
  - These days if_changed is used with many more commands than ld,
    objcopy, and gzip, hence add an ellipsis,
  - Any target that utilises if_changed must be listed in $(targets),
    so it needs an assignment to "targets", not "target".

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Michal Marek <mmarek@suse.cz>
  • Loading branch information
Geert Uytterhoeven authored and Michal Marek committed Aug 19, 2014
1 parent b22ae40 commit ef80f0a
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions Documentation/kbuild/makefiles.txt
Original file line number Diff line number Diff line change
Expand Up @@ -1092,7 +1092,7 @@ When kbuild executes, the following steps are followed (roughly):

Usage:
target: source(s) FORCE
$(call if_changed,ld/objcopy/gzip)
$(call if_changed,ld/objcopy/gzip/...)

When the rule is evaluated, it is checked to see if any files
need an update, or the command line has changed since the last
Expand All @@ -1110,7 +1110,7 @@ When kbuild executes, the following steps are followed (roughly):
significant; for instance, the below will fail (note the extra space
after the comma):
target: source(s) FORCE
#WRONG!# $(call if_changed, ld/objcopy/gzip)
#WRONG!# $(call if_changed, ld/objcopy/gzip/...)

ld
Link target. Often, LDFLAGS_$@ is used to set specific options to ld.
Expand Down Expand Up @@ -1142,7 +1142,7 @@ When kbuild executes, the following steps are followed (roughly):

The ": %: %.o" part of the prerequisite is a shorthand that
free us from listing the setup.o and bootsect.o files.
Note: It is a common mistake to forget the "target :=" assignment,
Note: It is a common mistake to forget the "targets :=" assignment,
resulting in the target file being recompiled for no
obvious reason.

Expand Down

0 comments on commit ef80f0a

Please sign in to comment.