Skip to content

Commit

Permalink
net: pktgen: Deletion of an unnecessary check before the function cal…
Browse files Browse the repository at this point in the history
…l "proc_remove"

The proc_remove() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Markus Elfring authored and David S. Miller committed Nov 19, 2014
1 parent 1abe7cd commit ef87c5d
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions net/core/pktgen.c
Original file line number Diff line number Diff line change
Expand Up @@ -3728,8 +3728,7 @@ static int pktgen_remove_device(struct pktgen_thread *t,
/* Remove proc before if_list entry, because add_device uses
* list to determine if interface already exist, avoid race
* with proc_create_data() */
if (pkt_dev->entry)
proc_remove(pkt_dev->entry);
proc_remove(pkt_dev->entry);

/* And update the thread if_list */
_rem_dev_from_if_list(t, pkt_dev);
Expand Down

0 comments on commit ef87c5d

Please sign in to comment.