Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 360533
b: refs/heads/master
c: 03696e5
h: refs/heads/master
i:
  360531: 1aa2257
v: v3
  • Loading branch information
Maxim Mikityanskiy authored and Matthew Garrett committed Feb 24, 2013
1 parent 31d3858 commit efaace4
Show file tree
Hide file tree
Showing 2 changed files with 28 additions and 13 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: cdeaf3868352592b206a08039b67c80c10ade8d5
refs/heads/master: 03696e51d75a3f23feb6b63dc6f3976a64c40b12
39 changes: 27 additions & 12 deletions trunk/drivers/platform/x86/msi-laptop.c
Original file line number Diff line number Diff line change
Expand Up @@ -546,8 +546,6 @@ static DEVICE_ATTR(turbo_cooldown, 0444, show_turbo_cooldown, NULL);
static DEVICE_ATTR(auto_fan, 0644, show_auto_fan, store_auto_fan);

static struct attribute *msipf_attributes[] = {
&dev_attr_lcd_level.attr,
&dev_attr_auto_brightness.attr,
&dev_attr_bluetooth.attr,
&dev_attr_wlan.attr,
&dev_attr_touchpad.attr,
Expand All @@ -558,10 +556,20 @@ static struct attribute *msipf_attributes[] = {
NULL
};

static struct attribute *msipf_old_attributes[] = {
&dev_attr_lcd_level.attr,
&dev_attr_auto_brightness.attr,
NULL
};

static struct attribute_group msipf_attribute_group = {
.attrs = msipf_attributes
};

static struct attribute_group msipf_old_attribute_group = {
.attrs = msipf_old_attributes
};

static struct platform_driver msipf_driver = {
.driver = {
.name = "msi-laptop-pf",
Expand Down Expand Up @@ -1062,7 +1070,7 @@ static int __init msi_init(void)

/* Register backlight stuff */

if (acpi_video_backlight_support()) {
if (!quirks->old_ec_model || acpi_video_backlight_support()) {
pr_info("Brightness ignored, must be controlled by ACPI video driver\n");
} else {
struct backlight_properties props;
Expand Down Expand Up @@ -1108,14 +1116,19 @@ static int __init msi_init(void)
&dev_attr_threeg);
if (ret)
goto fail_platform_device2;
}
} else {
ret = sysfs_create_group(&msipf_device->dev.kobj,
&msipf_old_attribute_group);
if (ret)
goto fail_platform_device2;

/* Disable automatic brightness control by default because
* this module was probably loaded to do brightness control in
* software. */
/* Disable automatic brightness control by default because
* this module was probably loaded to do brightness control in
* software. */

if (auto_brightness != 2)
set_auto_brightness(auto_brightness);
if (auto_brightness != 2)
set_auto_brightness(auto_brightness);
}

pr_info("driver " MSI_DRIVER_VERSION " successfully loaded\n");

Expand Down Expand Up @@ -1163,9 +1176,11 @@ static void __exit msi_cleanup(void)
platform_driver_unregister(&msipf_driver);
backlight_device_unregister(msibl_device);

/* Enable automatic brightness control again */
if (auto_brightness != 2)
set_auto_brightness(1);
if (quirks->old_ec_model) {
/* Enable automatic brightness control again */
if (auto_brightness != 2)
set_auto_brightness(1);
}

pr_info("driver unloaded\n");
}
Expand Down

0 comments on commit efaace4

Please sign in to comment.