Skip to content

Commit

Permalink
sched: idle_balance() does not call load_balance_newidle()
Browse files Browse the repository at this point in the history
Impact: fix SD_BALANCE_NEWIDLEand broaden its use

load_balance_newidle() does not get called if SD_BALANCE_NEWIDLE is
set at higher level domain (3-CPU) and not in low level domain (2-MC).

pulled_task is initialised to -1 and checked for non-zero which is
always true if the lowest level sched_domain does not have
SD_BALANCE_NEWIDLE flag set.

Signed-off-by: Vaidyanathan Srinivasan <svaidy@linux.vnet.ibm.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
  • Loading branch information
Vaidyanathan Srinivasan authored and Ingo Molnar committed Dec 8, 2008
1 parent 5436499 commit efbe027
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion kernel/sched.c
Original file line number Diff line number Diff line change
Expand Up @@ -3685,7 +3685,7 @@ load_balance_newidle(int this_cpu, struct rq *this_rq, struct sched_domain *sd,
static void idle_balance(int this_cpu, struct rq *this_rq)
{
struct sched_domain *sd;
int pulled_task = -1;
int pulled_task = 0;
unsigned long next_balance = jiffies + HZ;
cpumask_t tmpmask;

Expand Down

0 comments on commit efbe027

Please sign in to comment.