Skip to content

Commit

Permalink
mac80211: Speedup ieee80211_remove_interfaces()
Browse files Browse the repository at this point in the history
Speedup ieee80211_remove_interfaces() by factorizing synchronize_rcu() calls

Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Reviewed-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
  • Loading branch information
Eric Dumazet authored and John W. Linville committed Nov 25, 2009
1 parent 4ba3eb0 commit efe117a
Showing 1 changed file with 5 additions and 9 deletions.
14 changes: 5 additions & 9 deletions net/mac80211/iface.c
Original file line number Diff line number Diff line change
Expand Up @@ -860,22 +860,18 @@ void ieee80211_if_remove(struct ieee80211_sub_if_data *sdata)
void ieee80211_remove_interfaces(struct ieee80211_local *local)
{
struct ieee80211_sub_if_data *sdata, *tmp;
LIST_HEAD(unreg_list);

ASSERT_RTNL();

mutex_lock(&local->iflist_mtx);
list_for_each_entry_safe(sdata, tmp, &local->interfaces, list) {
/*
* we cannot hold the iflist_mtx across unregister_netdevice,
* but we only need to hold it for list modifications to lock
* out readers since we're under the RTNL here as all other
* writers.
*/
mutex_lock(&local->iflist_mtx);
list_del(&sdata->list);
mutex_unlock(&local->iflist_mtx);

unregister_netdevice(sdata->dev);
unregister_netdevice_queue(sdata->dev, &unreg_list);
}
mutex_unlock(&local->iflist_mtx);
unregister_netdevice_many(&unreg_list);
}

static u32 ieee80211_idle_off(struct ieee80211_local *local,
Expand Down

0 comments on commit efe117a

Please sign in to comment.