Skip to content

Commit

Permalink
staging: rtl8192e: use is_zero_ether_addr() instead of memcmp()
Browse files Browse the repository at this point in the history
Using is_zero_ether_addr() instead of directly use
memcmp() to determine if the ethernet address is all
zeros.

spatch with a semantic match is used to found this problem.
(http://coccinelle.lip6.fr/)

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Wei Yongjun authored and Greg Kroah-Hartman committed Sep 4, 2012
1 parent f6aa782 commit efe13d8
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions drivers/staging/rtl8192e/rtllib_softmac_wx.c
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@
*/


#include <linux/etherdevice.h>

#include "rtllib.h"
#include "dot11d.h"
/* FIXME: add A freqs */
Expand Down Expand Up @@ -137,7 +139,6 @@ int rtllib_wx_set_wap(struct rtllib_device *ieee,
{

int ret = 0;
u8 zero[] = {0, 0, 0, 0, 0, 0};
unsigned long flags;

short ifup = ieee->proto_started;
Expand All @@ -157,7 +158,7 @@ int rtllib_wx_set_wap(struct rtllib_device *ieee,
goto out;
}

if (memcmp(temp->sa_data, zero, ETH_ALEN) == 0) {
if (is_zero_ether_addr(temp->sa_data)) {
spin_lock_irqsave(&ieee->lock, flags);
memcpy(ieee->current_network.bssid, temp->sa_data, ETH_ALEN);
ieee->wap_set = 0;
Expand All @@ -177,7 +178,7 @@ int rtllib_wx_set_wap(struct rtllib_device *ieee,

ieee->cannot_notify = false;
memcpy(ieee->current_network.bssid, temp->sa_data, ETH_ALEN);
ieee->wap_set = (memcmp(temp->sa_data, zero, ETH_ALEN) != 0);
ieee->wap_set = !is_zero_ether_addr(temp->sa_data);

spin_unlock_irqrestore(&ieee->lock, flags);

Expand Down

0 comments on commit efe13d8

Please sign in to comment.