Skip to content

Commit

Permalink
omap1: Simplify use of omap_irq_flags
Browse files Browse the repository at this point in the history
Commit 03a9e51
(omap1: Use asm_irq_flags for entry-macro.S) added support
for multi-omap builds with addition of the omap_irq_flags.

Commit 9f9605c
(omap2+: Fix unused variable warning for omap_irq_base)
simplified omap2+ entry-macro.S by moving omap_irq_flags
out of entry-macro.S.

Simplify omap1 entry-macro.S in a similar way to keep the
code consistent. Based on a similar earlier patch for omap2+
by Russell King <rmk+kernel@arm.linux.org.uk>.

Signed-off-by: Tony Lindgren <tony@atomide.com>
  • Loading branch information
Tony Lindgren committed Jan 27, 2011
1 parent 9f9605c commit efe318a
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 14 deletions.
13 changes: 0 additions & 13 deletions arch/arm/mach-omap1/include/mach/entry-macro.S
Original file line number Diff line number Diff line change
Expand Up @@ -14,19 +14,6 @@
#include <mach/irqs.h>
#include <asm/hardware/gic.h>

/*
* We use __glue to avoid errors with multiple definitions of
* .globl omap_irq_flags as it's included from entry-armv.S but not
* from entry-common.S.
*/
#ifdef __glue
.pushsection .data
.globl omap_irq_flags
omap_irq_flags:
.word 0
.popsection
#endif

.macro disable_fiq
.endm

Expand Down
2 changes: 1 addition & 1 deletion arch/arm/mach-omap1/irq.c
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ struct omap_irq_bank {
unsigned long wake_enable;
};

u32 omap_irq_flags;
static unsigned int irq_bank_count;
static struct omap_irq_bank *irq_banks;

Expand Down Expand Up @@ -176,7 +177,6 @@ static struct irq_chip omap_irq_chip = {

void __init omap_init_irq(void)
{
extern unsigned int omap_irq_flags;
int i, j;

#if defined(CONFIG_ARCH_OMAP730) || defined(CONFIG_ARCH_OMAP850)
Expand Down

0 comments on commit efe318a

Please sign in to comment.