Skip to content

Commit

Permalink
drm/i915: Revert extra intel_wait_for_vblank to prevent stalls.
Browse files Browse the repository at this point in the history
With the extra intel_wait_for_vblank added in commit
9d0498a periodic stalls were being
triggered (which were detected by i915_hangcheck_elapsed). Partially
revert this change for now.

Signed-off-by: Sitsofe Wheeler <sitsofe@yahoo.com>
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
  • Loading branch information
Sitsofe Wheeler authored and Chris Wilson committed Sep 8, 2010
1 parent 2bbda38 commit efe8c25
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions drivers/gpu/drm/i915/intel_display.c
Original file line number Diff line number Diff line change
Expand Up @@ -2328,8 +2328,10 @@ static void i9xx_crtc_dpms(struct drm_crtc *crtc, int mode)
I915_READ(dspbase_reg);
}

/* Wait for vblank for the disable to take effect */
intel_wait_for_vblank_off(dev, pipe);
if (!IS_I9XX(dev)) {
/* Wait for vblank for the disable to take effect */
intel_wait_for_vblank_off(dev, pipe);
}

/* Don't disable pipe A or pipe A PLLs if needed */
if (pipeconf_reg == PIPEACONF &&
Expand Down

0 comments on commit efe8c25

Please sign in to comment.