Skip to content

Commit

Permalink
sctp: several declared/set but unused fixes
Browse files Browse the repository at this point in the history
Signed-off-by: Hagen Paul Pfeifer <hagen@jauu.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Hagen Paul Pfeifer authored and David S. Miller committed Mar 7, 2011
1 parent e143038 commit efea2c6
Show file tree
Hide file tree
Showing 6 changed files with 1 addition and 18 deletions.
2 changes: 0 additions & 2 deletions net/sctp/associola.c
Original file line number Diff line number Diff line change
Expand Up @@ -1089,15 +1089,13 @@ static void sctp_assoc_bh_rcv(struct work_struct *work)
base.inqueue.immediate);
struct sctp_endpoint *ep;
struct sctp_chunk *chunk;
struct sock *sk;
struct sctp_inq *inqueue;
int state;
sctp_subtype_t subtype;
int error = 0;

/* The association should be held so we should be safe. */
ep = asoc->ep;
sk = asoc->base.sk;

inqueue = &asoc->base.inqueue;
sctp_association_hold(asoc);
Expand Down
3 changes: 0 additions & 3 deletions net/sctp/input.c
Original file line number Diff line number Diff line change
Expand Up @@ -948,14 +948,11 @@ static struct sctp_association *__sctp_rcv_init_lookup(struct sk_buff *skb,
union sctp_addr addr;
union sctp_addr *paddr = &addr;
struct sctphdr *sh = sctp_hdr(skb);
sctp_chunkhdr_t *ch;
union sctp_params params;
sctp_init_chunk_t *init;
struct sctp_transport *transport;
struct sctp_af *af;

ch = (sctp_chunkhdr_t *) skb->data;

/*
* This code will NOT touch anything inside the chunk--it is
* strictly READ-ONLY.
Expand Down
2 changes: 0 additions & 2 deletions net/sctp/outqueue.c
Original file line number Diff line number Diff line change
Expand Up @@ -545,13 +545,11 @@ static int sctp_outq_flush_rtx(struct sctp_outq *q, struct sctp_packet *pkt,
struct sctp_transport *transport = pkt->transport;
sctp_xmit_t status;
struct sctp_chunk *chunk, *chunk1;
struct sctp_association *asoc;
int fast_rtx;
int error = 0;
int timer = 0;
int done = 0;

asoc = q->asoc;
lqueue = &q->retransmit;
fast_rtx = q->fast_rtx;

Expand Down
3 changes: 0 additions & 3 deletions net/sctp/sm_make_chunk.c
Original file line number Diff line number Diff line change
Expand Up @@ -3375,7 +3375,6 @@ struct sctp_chunk *sctp_make_fwdtsn(const struct sctp_association *asoc,
struct sctp_fwdtsn_skip *skiplist)
{
struct sctp_chunk *retval = NULL;
struct sctp_fwdtsn_chunk *ftsn_chunk;
struct sctp_fwdtsn_hdr ftsn_hdr;
struct sctp_fwdtsn_skip skip;
size_t hint;
Expand All @@ -3388,8 +3387,6 @@ struct sctp_chunk *sctp_make_fwdtsn(const struct sctp_association *asoc,
if (!retval)
return NULL;

ftsn_chunk = (struct sctp_fwdtsn_chunk *)retval->subh.fwdtsn_hdr;

ftsn_hdr.new_cum_tsn = htonl(new_cum_tsn);
retval->subh.fwdtsn_hdr =
sctp_addto_chunk(retval, sizeof(ftsn_hdr), &ftsn_hdr);
Expand Down
2 changes: 0 additions & 2 deletions net/sctp/socket.c
Original file line number Diff line number Diff line change
Expand Up @@ -2928,15 +2928,13 @@ static int sctp_setsockopt_peer_primary_addr(struct sock *sk, char __user *optva
unsigned int optlen)
{
struct sctp_sock *sp;
struct sctp_endpoint *ep;
struct sctp_association *asoc = NULL;
struct sctp_setpeerprim prim;
struct sctp_chunk *chunk;
struct sctp_af *af;
int err;

sp = sctp_sk(sk);
ep = sp->ep;

if (!sctp_addip_enable)
return -EPERM;
Expand Down
7 changes: 1 addition & 6 deletions net/sctp/ulpqueue.c
Original file line number Diff line number Diff line change
Expand Up @@ -105,11 +105,8 @@ int sctp_ulpq_tail_data(struct sctp_ulpq *ulpq, struct sctp_chunk *chunk,
gfp_t gfp)
{
struct sk_buff_head temp;
sctp_data_chunk_t *hdr;
struct sctp_ulpevent *event;

hdr = (sctp_data_chunk_t *) chunk->chunk_hdr;

/* Create an event from the incoming chunk. */
event = sctp_ulpevent_make_rcvmsg(chunk->asoc, chunk, gfp);
if (!event)
Expand Down Expand Up @@ -743,11 +740,9 @@ static void sctp_ulpq_retrieve_ordered(struct sctp_ulpq *ulpq,
struct sk_buff *pos, *tmp;
struct sctp_ulpevent *cevent;
struct sctp_stream *in;
__u16 sid, csid;
__u16 ssn, cssn;
__u16 sid, csid, cssn;

sid = event->stream;
ssn = event->ssn;
in = &ulpq->asoc->ssnmap->in;

event_list = (struct sk_buff_head *) sctp_event2skb(event)->prev;
Expand Down

0 comments on commit efea2c6

Please sign in to comment.