Skip to content

Commit

Permalink
clocksource: pass DT node pointer to init functions
Browse files Browse the repository at this point in the history
In cases where we have multiple nodes of the same type, we may need the
node pointer to know which node was matched. Passing the node pointer
also keeps the init function from having to match the node a 2nd time.

Update bcm2835, vt8500, and tegra20 init functions for the new function
prototype. Further tegra20 clean-ups are in follow-up commit.

Signed-off-by: Rob Herring <rob.herring@calxeda.com>
Cc: John Stultz <johnstul@us.ibm.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Stephen Warren <swarren@nvidia.com>
Tested-by: Stephen Warren <swarren@nvidia.com>
Acked-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Tony Prisk <linux@prisktech.co.nz>
Tested-by: Michal Simek <michal.simek@xilinx.com>
  • Loading branch information
Rob Herring committed Mar 11, 2013
1 parent e0c2536 commit effbfdd
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 28 deletions.
12 changes: 1 addition & 11 deletions drivers/clocksource/bcm2835_timer.c
Original file line number Diff line number Diff line change
Expand Up @@ -95,23 +95,13 @@ static irqreturn_t bcm2835_time_interrupt(int irq, void *dev_id)
}
}

static struct of_device_id bcm2835_time_match[] __initconst = {
{ .compatible = "brcm,bcm2835-system-timer" },
{}
};

static void __init bcm2835_timer_init(void)
static void __init bcm2835_timer_init(struct device_node *node)
{
struct device_node *node;
void __iomem *base;
u32 freq;
int irq;
struct bcm2835_timer *timer;

node = of_find_matching_node(NULL, bcm2835_time_match);
if (!node)
panic("No bcm2835 timer node");

base = of_iomap(node, 0);
if (!base)
panic("Can't remap registers");
Expand Down
4 changes: 2 additions & 2 deletions drivers/clocksource/clksrc-of.c
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,10 @@ void __init clocksource_of_init(void)
{
struct device_node *np;
const struct of_device_id *match;
void (*init_func)(void);
void (*init_func)(struct device_node *);

for_each_matching_node_and_match(np, __clksrc_of_table, &match) {
init_func = match->data;
init_func();
init_func(np);
}
}
3 changes: 1 addition & 2 deletions drivers/clocksource/tegra20_timer.c
Original file line number Diff line number Diff line change
Expand Up @@ -164,9 +164,8 @@ static const struct of_device_id rtc_match[] __initconst = {
{}
};

static void __init tegra20_init_timer(void)
static void __init tegra20_init_timer(struct device_node *np)
{
struct device_node *np;
struct clk *clk;
unsigned long rate;
int ret;
Expand Down
14 changes: 1 addition & 13 deletions drivers/clocksource/vt8500_timer.c
Original file line number Diff line number Diff line change
Expand Up @@ -129,22 +129,10 @@ static struct irqaction irq = {
.dev_id = &clockevent,
};

static struct of_device_id vt8500_timer_ids[] = {
{ .compatible = "via,vt8500-timer" },
{ }
};

static void __init vt8500_timer_init(void)
static void __init vt8500_timer_init(struct device_node *np)
{
struct device_node *np;
int timer_irq;

np = of_find_matching_node(NULL, vt8500_timer_ids);
if (!np) {
pr_err("%s: Timer description missing from Device Tree\n",
__func__);
return;
}
regbase = of_iomap(np, 0);
if (!regbase) {
pr_err("%s: Missing iobase description in Device Tree\n",
Expand Down

0 comments on commit effbfdd

Please sign in to comment.