Skip to content

Commit

Permalink
[media] au0828: Replace memcpy with struct assignment
Browse files Browse the repository at this point in the history
This kind of memcpy() is error-prone. Its replacement with a struct
assignment is prefered because it's type-safe and much easier to read.
Found by coccinelle. Hand patched and reviewed.
Tested by compilation only.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
@@
identifier struct_name;
struct struct_name to;
struct struct_name from;
expression E;
@@
-memcpy(&(to), &(from), E);
+to = from;
// </smpl>

Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
Signed-off-by: Ezequiel Garcia <elezegarcia@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
  • Loading branch information
Ezequiel Garcia authored and Mauro Carvalho Chehab committed Dec 27, 2012
1 parent d3a9509 commit f01e0ff
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 7 deletions.
2 changes: 1 addition & 1 deletion drivers/media/usb/au0828/au0828-cards.c
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ void au0828_card_setup(struct au0828_dev *dev)

dprintk(1, "%s()\n", __func__);

memcpy(&dev->board, &au0828_boards[dev->boardnr], sizeof(dev->board));
dev->board = au0828_boards[dev->boardnr];

if (dev->i2c_rc == 0) {
dev->i2c_client.addr = 0xa0 >> 1;
Expand Down
9 changes: 3 additions & 6 deletions drivers/media/usb/au0828/au0828-i2c.c
Original file line number Diff line number Diff line change
Expand Up @@ -364,12 +364,9 @@ int au0828_i2c_register(struct au0828_dev *dev)
{
dprintk(1, "%s()\n", __func__);

memcpy(&dev->i2c_adap, &au0828_i2c_adap_template,
sizeof(dev->i2c_adap));
memcpy(&dev->i2c_algo, &au0828_i2c_algo_template,
sizeof(dev->i2c_algo));
memcpy(&dev->i2c_client, &au0828_i2c_client_template,
sizeof(dev->i2c_client));
dev->i2c_adap = au0828_i2c_adap_template;
dev->i2c_algo = au0828_i2c_algo_template;
dev->i2c_client = au0828_i2c_client_template;

dev->i2c_adap.dev.parent = &dev->usbdev->dev;

Expand Down

0 comments on commit f01e0ff

Please sign in to comment.