Skip to content

Commit

Permalink
[PATCH] Enhancing accessibility of lxdialog
Browse files Browse the repository at this point in the history
For easily getting fairly good accessibility, the TTY cursor should
always be left at the focus location.  This patch fixes the checklist by
just having the list refreshed after the dialog box (hence the cursor
position remains in the list).

Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
  • Loading branch information
Samuel Thibault authored and Linus Torvalds committed Apr 14, 2006
1 parent 9a7e9f1 commit f043ca4
Showing 1 changed file with 9 additions and 10 deletions.
19 changes: 9 additions & 10 deletions scripts/kconfig/lxdialog/checklist.c
Original file line number Diff line number Diff line change
Expand Up @@ -196,8 +196,8 @@ int dialog_checklist(const char *title, const char *prompt, int height,

print_buttons(dialog, height, width, 0);

wnoutrefresh(list);
wnoutrefresh(dialog);
wnoutrefresh(list);
doupdate();

while (key != ESC) {
Expand Down Expand Up @@ -225,12 +225,11 @@ int dialog_checklist(const char *title, const char *prompt, int height,
}
scroll--;
print_item(list, items[scroll * 3 + 1], status[scroll], 0, TRUE);
wnoutrefresh(list);

print_arrows(dialog, choice, item_no,
scroll, box_y, box_x + check_x + 5, list_height);

wrefresh(dialog);
wnoutrefresh(dialog);
wrefresh(list);

continue; /* wait for another key press */
} else
Expand All @@ -252,12 +251,12 @@ int dialog_checklist(const char *title, const char *prompt, int height,
scroll++;
print_item(list, items[(scroll + max_choice - 1) * 3 + 1],
status[scroll + max_choice - 1], max_choice - 1, TRUE);
wnoutrefresh(list);

print_arrows(dialog, choice, item_no,
scroll, box_y, box_x + check_x + 5, list_height);

wrefresh(dialog);
wnoutrefresh(dialog);
wrefresh(list);

continue; /* wait for another key press */
} else
Expand All @@ -271,8 +270,8 @@ int dialog_checklist(const char *title, const char *prompt, int height,
choice = i;
print_item(list, items[(scroll + choice) * 3 + 1],
status[scroll + choice], choice, TRUE);
wnoutrefresh(list);
wrefresh(dialog);
wnoutrefresh(dialog);
wrefresh(list);
}
continue; /* wait for another key press */
}
Expand Down Expand Up @@ -306,8 +305,8 @@ int dialog_checklist(const char *title, const char *prompt, int height,
print_item(list, items[(scroll + i) * 3 + 1],
status[scroll + i], i, i == choice);
}
wnoutrefresh(list);
wrefresh(dialog);
wnoutrefresh(dialog);
wrefresh(list);

for (i = 0; i < item_no; i++)
if (status[i])
Expand Down

0 comments on commit f043ca4

Please sign in to comment.