Skip to content

Commit

Permalink
checkpatch: report the correct lines for single statement blocks
Browse files Browse the repository at this point in the history
Report the correct lines for single statement blocks.  Currently we are
reporting the right number of lines, but not skipping the negative lines.

Signed-off-by: Andy Whitcroft <apw@shadowen.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Andy Whitcroft authored and Linus Torvalds committed Oct 16, 2008
1 parent 2a1bc5d commit f055663
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions scripts/checkpatch.pl
Original file line number Diff line number Diff line change
Expand Up @@ -2214,10 +2214,10 @@ sub process {
}
if ($level == 0 && $block =~ /^\s*\{/ && !$allowed) {
my $herectx = $here . "\n";;
my $end = $linenr + statement_rawlines($block) - 1;
my $cnt = statement_rawlines($block);

for (my $ln = $linenr - 1; $ln < $end; $ln++) {
$herectx .= $rawlines[$ln] . "\n";;
for (my $n = 0; $n < $cnt; $n++) {
$herectx .= raw_line($linenr, $n) . "\n";;
}

WARN("braces {} are not necessary for single statement blocks\n" . $herectx);
Expand Down

0 comments on commit f055663

Please sign in to comment.