Skip to content

Commit

Permalink
netprio_cgroup: Use memcpy instead of the for-loop to copy priomap
Browse files Browse the repository at this point in the history
Replace the current (inefficient) for-loop with memcpy, to copy priomap.

Signed-off-by: Srivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Srivatsa S. Bhat authored and David S. Miller committed Sep 13, 2012
1 parent d530d6d commit f05ba7f
Showing 1 changed file with 4 additions and 5 deletions.
9 changes: 4 additions & 5 deletions net/core/netprio_cgroup.c
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,6 @@ static int extend_netdev_table(struct net_device *dev, u32 new_len)
((sizeof(u32) * new_len));
struct netprio_map *new_priomap = kzalloc(new_size, GFP_KERNEL);
struct netprio_map *old_priomap;
int i;

old_priomap = rtnl_dereference(dev->priomap);

Expand All @@ -82,10 +81,10 @@ static int extend_netdev_table(struct net_device *dev, u32 new_len)
return -ENOMEM;
}

for (i = 0;
old_priomap && (i < old_priomap->priomap_len);
i++)
new_priomap->priomap[i] = old_priomap->priomap[i];
if (old_priomap)
memcpy(new_priomap->priomap, old_priomap->priomap,
old_priomap->priomap_len *
sizeof(old_priomap->priomap[0]));

new_priomap->priomap_len = new_len;

Expand Down

0 comments on commit f05ba7f

Please sign in to comment.