Skip to content

Commit

Permalink
Introduce down_killable()
Browse files Browse the repository at this point in the history
down_killable() is the functional counterpart of mutex_lock_killable.

Signed-off-by: Matthew Wilcox <willy@linux.intel.com>
  • Loading branch information
Matthew Wilcox authored and Matthew Wilcox committed Apr 17, 2008
1 parent 64ac24e commit f06d968
Show file tree
Hide file tree
Showing 2 changed files with 28 additions and 0 deletions.
6 changes: 6 additions & 0 deletions include/linux/semaphore.h
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,12 @@ extern void down(struct semaphore *sem);
*/
extern int __must_check down_interruptible(struct semaphore *sem);

/*
* As down_interruptible(), except the sleep may only be interrupted by
* signals which are fatal to this process.
*/
extern int __must_check down_killable(struct semaphore *sem);

/*
* As down(), except this function will not sleep. It will return 0 if it
* acquired the semaphore and 1 if the semaphore was contended. This
Expand Down
22 changes: 22 additions & 0 deletions kernel/semaphore.c
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@

static noinline void __down(struct semaphore *sem);
static noinline int __down_interruptible(struct semaphore *sem);
static noinline int __down_killable(struct semaphore *sem);
static noinline void __up(struct semaphore *sem);

void down(struct semaphore *sem)
Expand Down Expand Up @@ -61,6 +62,20 @@ int down_interruptible(struct semaphore *sem)
}
EXPORT_SYMBOL(down_interruptible);

int down_killable(struct semaphore *sem)
{
unsigned long flags;
int result = 0;

spin_lock_irqsave(&sem->lock, flags);
if (unlikely(sem->count-- <= 0))
result = __down_killable(sem);
spin_unlock_irqrestore(&sem->lock, flags);

return result;
}
EXPORT_SYMBOL(down_killable);

/**
* down_trylock - try to acquire the semaphore, without waiting
* @sem: the semaphore to be acquired
Expand Down Expand Up @@ -143,6 +158,8 @@ static inline int __sched __down_common(struct semaphore *sem, long state)
for (;;) {
if (state == TASK_INTERRUPTIBLE && signal_pending(task))
goto interrupted;
if (state == TASK_KILLABLE && fatal_signal_pending(task))
goto interrupted;
__set_task_state(task, state);
spin_unlock_irq(&sem->lock);
schedule();
Expand Down Expand Up @@ -178,6 +195,11 @@ static noinline int __sched __down_interruptible(struct semaphore *sem)
return __down_common(sem, TASK_INTERRUPTIBLE);
}

static noinline int __sched __down_killable(struct semaphore *sem)
{
return __down_common(sem, TASK_KILLABLE);
}

static noinline void __sched __up(struct semaphore *sem)
{
if (unlikely(list_empty(&sem->wait_list)))
Expand Down

0 comments on commit f06d968

Please sign in to comment.