Skip to content

Commit

Permalink
tcp: remove retransmit_skb_hint clearing from failure
Browse files Browse the repository at this point in the history
This doesn't much sense here afaict, probably never has. Since
fragmenting and collapsing deal the hints by themselves, there
should be very little reason for the rexmit loop to do that.

Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@helsinki.fi>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Ilpo Järvinen authored and David S. Miller committed Sep 21, 2008
1 parent 0e1c54c commit f0ceb0e
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions net/ipv4/tcp_output.c
Original file line number Diff line number Diff line change
Expand Up @@ -2096,10 +2096,8 @@ void tcp_xmit_retransmit_queue(struct sock *sk)
if (sacked & (TCPCB_SACKED_ACKED|TCPCB_SACKED_RETRANS))
continue;

if (tcp_retransmit_skb(sk, skb)) {
tp->retransmit_skb_hint = NULL;
if (tcp_retransmit_skb(sk, skb))
return;
}
NET_INC_STATS_BH(sock_net(sk), mib_idx);

if (skb == tcp_write_queue_head(sk))
Expand Down

0 comments on commit f0ceb0e

Please sign in to comment.