Skip to content

Commit

Permalink
USB: improve ehci_watchdog's side effect in CPU power management
Browse files Browse the repository at this point in the history
ehci_watchdog will wake up CPU very frequently so that CPU
stays at C3 very short, average residence time is about 50
ms on Aspire One, but we expect it should be about 1 second
or more, so this kind of periodic timer is very bad for power
saving.

We can't remove this timer because of some bad USB controller
chipset, but at least we should reduce its side effect to as
possible as low.

This patch can make CPU stay at C3 longer, average residence time
is about twice as long as original. 

Please consider to apply it, thanks

Signed-off-by: Yi Yang <yi.y.yang@intel.com>
Cc: David Brownell <dbrownell@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
Yi Yang authored and Greg Kroah-Hartman committed Oct 17, 2008
1 parent e58dceb commit f0d781d
Showing 1 changed file with 7 additions and 5 deletions.
12 changes: 7 additions & 5 deletions drivers/usb/host/ehci.h
Original file line number Diff line number Diff line change
Expand Up @@ -181,14 +181,16 @@ timer_action (struct ehci_hcd *ehci, enum ehci_timer_action action)
* the async ring; just the I/O watchdog. Note that if a
* SHRINK were pending, OFF would never be requested.
*/
if (timer_pending(&ehci->watchdog)
&& ((BIT(TIMER_ASYNC_SHRINK) | BIT(TIMER_ASYNC_OFF))
& ehci->actions))
return;
enum ehci_timer_action oldactions = ehci->actions;

if (!test_and_set_bit (action, &ehci->actions)) {
unsigned long t;

if (timer_pending(&ehci->watchdog)
&& ((BIT(TIMER_ASYNC_SHRINK) | BIT(TIMER_ASYNC_OFF))
& oldactions))
return;

switch (action) {
case TIMER_IO_WATCHDOG:
t = EHCI_IO_JIFFIES;
Expand All @@ -204,7 +206,7 @@ timer_action (struct ehci_hcd *ehci, enum ehci_timer_action action)
t = DIV_ROUND_UP(EHCI_SHRINK_FRAMES * HZ, 1000) + 1;
break;
}
mod_timer(&ehci->watchdog, t + jiffies);
mod_timer(&ehci->watchdog, round_jiffies(t + jiffies));
}
}

Expand Down

0 comments on commit f0d781d

Please sign in to comment.