Skip to content

Commit

Permalink
gpio: pca953x: remove unneeded check for chip type
Browse files Browse the repository at this point in the history
We can assume our own device_id table is correct, so remove checking if
the chip type is valid. (The check was bogus anyway: If it found an
invalid entry, it returned with 0!) This is in preparation for further
cleanups.

Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
Cc: Grant Likely <grant.likely@secretlab.ca>
Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
  • Loading branch information
Wolfram Sang authored and Grant Likely committed Oct 29, 2011
1 parent d92ef29 commit f0eb824
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions drivers/gpio/gpio-pca953x.c
Original file line number Diff line number Diff line change
Expand Up @@ -673,10 +673,8 @@ static int __devinit pca953x_probe(struct i2c_client *client,

if (chip->chip_type == PCA953X_TYPE)
device_pca953x_init(chip, invert);
else if (chip->chip_type == PCA957X_TYPE)
device_pca957x_init(chip, invert);
else
goto out_failed;
device_pca957x_init(chip, invert);

ret = pca953x_irq_setup(chip, id, irq_base);
if (ret)
Expand Down

0 comments on commit f0eb824

Please sign in to comment.