Skip to content

Commit

Permalink
Staging: sep: remove virtual address being passed to user space appli…
Browse files Browse the repository at this point in the history
…cation

Signed-off-by: Mark Allyn <mark.a.allyn@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
Mark Allyn authored and Greg Kroah-Hartman committed Dec 10, 2010
1 parent c5e6156 commit f156627
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 31 deletions.
23 changes: 5 additions & 18 deletions drivers/staging/sep/sep_driver.c
Original file line number Diff line number Diff line change
Expand Up @@ -2541,34 +2541,21 @@ static int sep_free_dma_tables_and_dcb(struct sep_device *sep, bool isapplet,
* This function sets the bus and virtual addresses of the static pool
* and returns the virtual address
*/
static int sep_get_static_pool_addr_handler(struct sep_device *sep,
unsigned long arg)
static int sep_get_static_pool_addr_handler(struct sep_device *sep)
{
struct stat_pool_addr_struct command_args;
u32 *static_pool_addr = NULL;
unsigned long addr_hold;

dev_dbg(&sep->pdev->dev, "sep_get_static_pool_addr_handler start\n");

static_pool_addr = (u32 *)(sep->shared_addr +
SEP_DRIVER_SYSTEM_RAR_MEMORY_OFFSET_IN_BYTES);

static_pool_addr[0] = SEP_STATIC_POOL_VAL_TOKEN;
static_pool_addr[1] = sep->shared_bus +
static_pool_addr[1] = (u32)sep->shared_bus +
SEP_DRIVER_STATIC_AREA_OFFSET_IN_BYTES;

addr_hold = (unsigned long)
(sep->shared_addr + SEP_DRIVER_STATIC_AREA_OFFSET_IN_BYTES);
command_args.static_virt_address = (aligned_u64)addr_hold;

dev_dbg(&sep->pdev->dev, "static pool: physical %x virtual %x\n",
(u32)static_pool_addr[1],
(u32)command_args.static_virt_address);

/* Send the parameters to user application */
if (copy_to_user((void __user *) arg, &command_args,
sizeof(struct stat_pool_addr_struct)))
return -EFAULT;
dev_dbg(&sep->pdev->dev, "static pool: physical %x\n",
(u32)static_pool_addr[1]);

dev_dbg(&sep->pdev->dev, "sep_get_static_pool_addr_handler end\n");

Expand Down Expand Up @@ -3064,7 +3051,7 @@ static long sep_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
break;
case SEP_IOCGETSTATICPOOLADDR:
/* Get the physical and virtual addresses of the static pool */
error = sep_get_static_pool_addr_handler(sep, arg);
error = sep_get_static_pool_addr_handler(sep);
break;
case SEP_IOCENDTRANSACTION:
error = sep_end_transaction_handler(sep);
Expand Down
14 changes: 1 addition & 13 deletions drivers/staging/sep/sep_driver_api.h
Original file line number Diff line number Diff line change
Expand Up @@ -114,18 +114,6 @@ struct bld_syn_tab_struct {

};

/*
* command struct for static pool addresses
* Please note that this is a kernel virtual
* address; this will be removed at the next
* release of the Discretix middleware
*/
struct stat_pool_addr_struct {
/* virtual address of the static pool */
aligned_u64 static_virt_address;
};


/* command struct for getting caller id value and address */
struct caller_id_struct {
/* pid of the process */
Expand Down Expand Up @@ -275,7 +263,7 @@ struct sep_lli_entry {

/* get the static pool area addersses (physical and virtual) */
#define SEP_IOCGETSTATICPOOLADDR \
_IOR(SEP_IOC_MAGIC_NUMBER, 8, struct stat_pool_addr_struct)
_IO(SEP_IOC_MAGIC_NUMBER, 8)

/* start sep command */
#define SEP_IOCSEPSTART \
Expand Down

0 comments on commit f156627

Please sign in to comment.