Skip to content

Commit

Permalink
clk: prima2: fix return value check in sirfsoc_of_clk_init()
Browse files Browse the repository at this point in the history
In case of error, the function clk_get() returns ERR_PTR()
not NULL. The NULL test in the return value check should
be replaced with IS_ERR().

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Acked-by: Barry Song <21cnbao@gmail.com>
Signed-off-by: Mike Turquette <mturquette@linaro.org>
[mturquette@linaro.org: added missing parenthesis to fix compile break]
  • Loading branch information
Wei Yongjun authored and Mike Turquette committed Mar 22, 2013
1 parent 0498172 commit f15ea6c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/clk/clk-prima2.c
Original file line number Diff line number Diff line change
Expand Up @@ -1113,7 +1113,7 @@ void __init sirfsoc_of_clk_init(void)

for (i = pll1; i < maxclk; i++) {
prima2_clks[i] = clk_register(NULL, prima2_clk_hw_array[i]);
BUG_ON(!prima2_clks[i]);
BUG_ON(IS_ERR(prima2_clks[i]));
}
clk_register_clkdev(prima2_clks[cpu], NULL, "cpu");
clk_register_clkdev(prima2_clks[io], NULL, "io");
Expand Down

0 comments on commit f15ea6c

Please sign in to comment.