Skip to content

Commit

Permalink
phylib: Remove unnecessary "reset" fixups in genphy_setup_forced
Browse files Browse the repository at this point in the history
genphy_setup_forced hasn't actually reset the PHY for a long time,
but a comment to that effect remained in the code, so code continued
to act as if it *had* reset the PHY, and called the necessary fixup
functions to respond to a PHY reset.  With no reset, those functions
are no longer needed, so we remove them.

Signed-off-by: Andy Fleming <afleming@freescale.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Andy Fleming authored and David S. Miller committed Dec 16, 2008
1 parent 5a5efed commit f162e97
Showing 1 changed file with 0 additions and 17 deletions.
17 changes: 0 additions & 17 deletions drivers/net/phy/phy_device.c
Original file line number Diff line number Diff line change
Expand Up @@ -517,23 +517,6 @@ int genphy_setup_forced(struct phy_device *phydev)

err = phy_write(phydev, MII_BMCR, ctl);

if (err < 0)
return err;

/*
* Run the fixups on this PHY, just in case the
* board code needs to change something after a reset
*/
err = phy_scan_fixups(phydev);

if (err < 0)
return err;

/* We just reset the device, so we'd better configure any
* settings the PHY requires to operate */
if (phydev->drv->config_init)
err = phydev->drv->config_init(phydev);

return err;
}

Expand Down

0 comments on commit f162e97

Please sign in to comment.