Skip to content

Commit

Permalink
[PATCH] ioremap balanced with iounmap for drivers/video/offb
Browse files Browse the repository at this point in the history
ioremap must be balanced by an iounmap and failing to do so can result in a
memory leak.

Signed-off-by: Amol Lad <amol@verismonetworks.com>
Cc: "Antonino A. Daplas" <adaplas@pol.net>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
  • Loading branch information
Amol Lad authored and Linus Torvalds committed Dec 8, 2006
1 parent 2b7574d commit f190017
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions drivers/video/offb.c
Original file line number Diff line number Diff line change
Expand Up @@ -402,6 +402,9 @@ static void __init offb_init_fb(const char *name, const char *full_name,
fb_alloc_cmap(&info->cmap, 256, 0);

if (register_framebuffer(info) < 0) {
iounmap(par->cmap_adr);
par->cmap_adr = NULL;
iounmap(info->screen_base);
kfree(info);
release_mem_region(res_start, res_size);
return;
Expand Down

0 comments on commit f190017

Please sign in to comment.