Skip to content

Commit

Permalink
staging: comedi: cb_das16_cs: refactor the pcmcia support code
Browse files Browse the repository at this point in the history
Refactor the pcmcia support code to remove the need for the
forward declarations.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
H Hartley Sweeten authored and Greg Kroah-Hartman committed Jun 26, 2012
1 parent 1b19f53 commit f19d857
Showing 1 changed file with 30 additions and 38 deletions.
68 changes: 30 additions & 38 deletions drivers/staging/comedi/drivers/cb_das16_cs.c
Original file line number Diff line number Diff line change
Expand Up @@ -623,48 +623,16 @@ static int das16cs_timer_insn_config(struct comedi_device *dev,
return -EINVAL;
}

static void das16cs_pcmcia_config(struct pcmcia_device *link);
static void das16cs_pcmcia_release(struct pcmcia_device *link);
static int das16cs_pcmcia_suspend(struct pcmcia_device *p_dev);
static int das16cs_pcmcia_resume(struct pcmcia_device *p_dev);

static int das16cs_pcmcia_attach(struct pcmcia_device *);
static void das16cs_pcmcia_detach(struct pcmcia_device *);

struct local_info_t {
struct pcmcia_device *link;
int stop;
struct bus_operations *bus;
};

static int das16cs_pcmcia_attach(struct pcmcia_device *link)
{
struct local_info_t *local;

dev_dbg(&link->dev, "das16cs_pcmcia_attach()\n");

/* Allocate space for private device-specific data */
local = kzalloc(sizeof(struct local_info_t), GFP_KERNEL);
if (!local)
return -ENOMEM;
local->link = link;
link->priv = local;

cur_dev = link;

das16cs_pcmcia_config(link);

return 0;
}

static void das16cs_pcmcia_detach(struct pcmcia_device *link)
static void das16cs_pcmcia_release(struct pcmcia_device *link)
{
dev_dbg(&link->dev, "das16cs_pcmcia_detach\n");

((struct local_info_t *)link->priv)->stop = 1;
das16cs_pcmcia_release(link);
/* This points to the parent struct local_info_t struct */
kfree(link->priv);
dev_dbg(&link->dev, "das16cs_pcmcia_release\n");
pcmcia_disable_device(link);
}

static int das16cs_pcmcia_config_loop(struct pcmcia_device *p_dev,
Expand Down Expand Up @@ -704,10 +672,34 @@ static void das16cs_pcmcia_config(struct pcmcia_device *link)
das16cs_pcmcia_release(link);
}

static void das16cs_pcmcia_release(struct pcmcia_device *link)
static int das16cs_pcmcia_attach(struct pcmcia_device *link)
{
dev_dbg(&link->dev, "das16cs_pcmcia_release\n");
pcmcia_disable_device(link);
struct local_info_t *local;

dev_dbg(&link->dev, "das16cs_pcmcia_attach()\n");

/* Allocate space for private device-specific data */
local = kzalloc(sizeof(struct local_info_t), GFP_KERNEL);
if (!local)
return -ENOMEM;
local->link = link;
link->priv = local;

cur_dev = link;

das16cs_pcmcia_config(link);

return 0;
}

static void das16cs_pcmcia_detach(struct pcmcia_device *link)
{
dev_dbg(&link->dev, "das16cs_pcmcia_detach\n");

((struct local_info_t *)link->priv)->stop = 1;
das16cs_pcmcia_release(link);
/* This points to the parent struct local_info_t struct */
kfree(link->priv);
}

static int das16cs_pcmcia_suspend(struct pcmcia_device *link)
Expand Down

0 comments on commit f19d857

Please sign in to comment.