Skip to content

Commit

Permalink
bus: brcmstb_gisb: register the fault code hook
Browse files Browse the repository at this point in the history
Commit 44127b7 ("bus: add Broadcom GISB bus arbiter timeout/error
handler") added everything that is required to register an ARM fault
handler for imprecise external aborts, except that there is nothing
calling this currently.

We do not need to export that specific function and have to update
arch/arm/mach-bcm/brcmstb.c to call it, simply, register the fault
handler during the probe() function of the driver.

Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
  • Loading branch information
Florian Fainelli committed Oct 20, 2014
1 parent 1aaaad3 commit f1bee78
Showing 1 changed file with 3 additions and 6 deletions.
9 changes: 3 additions & 6 deletions drivers/bus/brcmstb_gisb.c
Original file line number Diff line number Diff line change
Expand Up @@ -160,12 +160,6 @@ static int brcmstb_bus_error_handler(unsigned long addr, unsigned int fsr,
return ret;
}

void __init brcmstb_hook_fault_code(void)
{
hook_fault_code(22, brcmstb_bus_error_handler, SIGBUS, 0,
"imprecise external abort");
}

static irqreturn_t brcmstb_gisb_timeout_handler(int irq, void *dev_id)
{
brcmstb_gisb_arb_decode_addr(dev_id, "timeout");
Expand Down Expand Up @@ -261,6 +255,9 @@ static int brcmstb_gisb_arb_probe(struct platform_device *pdev)

list_add_tail(&gdev->next, &brcmstb_gisb_arb_device_list);

hook_fault_code(22, brcmstb_bus_error_handler, SIGBUS, 0,
"imprecise external abort");

dev_info(&pdev->dev, "registered mem: %p, irqs: %d, %d\n",
gdev->base, timeout_irq, tea_irq);

Expand Down

0 comments on commit f1bee78

Please sign in to comment.