Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 365501
b: refs/heads/master
c: c917808
h: refs/heads/master
i:
  365499: 983301e
v: v3
  • Loading branch information
Tejun Heo committed Mar 12, 2013
1 parent bcff54e commit f1e1d02
Show file tree
Hide file tree
Showing 2 changed files with 20 additions and 24 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: 75ccf5950f828d53aebfd3a852283a00abf2c5bf
refs/heads/master: c9178087acd71b4ea010ea48e147cf66952d2da9
42 changes: 19 additions & 23 deletions trunk/kernel/workqueue.c
Original file line number Diff line number Diff line change
Expand Up @@ -1209,6 +1209,7 @@ static void __queue_work(int cpu, struct workqueue_struct *wq,
struct work_struct *work)
{
struct pool_workqueue *pwq;
struct worker_pool *last_pool;
struct list_head *worklist;
unsigned int work_flags;
unsigned int req_cpu = cpu;
Expand All @@ -1228,41 +1229,36 @@ static void __queue_work(int cpu, struct workqueue_struct *wq,
WARN_ON_ONCE(!is_chained_work(wq)))
return;

/* determine the pwq to use */
/* pwq which will be used unless @work is executing elsewhere */
if (!(wq->flags & WQ_UNBOUND)) {
struct worker_pool *last_pool;

if (cpu == WORK_CPU_UNBOUND)
cpu = raw_smp_processor_id();

/*
* It's multi cpu. If @work was previously on a different
* cpu, it might still be running there, in which case the
* work needs to be queued on that cpu to guarantee
* non-reentrancy.
*/
pwq = per_cpu_ptr(wq->cpu_pwqs, cpu);
last_pool = get_work_pool(work);
} else {
pwq = first_pwq(wq);
}

if (last_pool && last_pool != pwq->pool) {
struct worker *worker;
/*
* If @work was previously on a different pool, it might still be
* running there, in which case the work needs to be queued on that
* pool to guarantee non-reentrancy.
*/
last_pool = get_work_pool(work);
if (last_pool && last_pool != pwq->pool) {
struct worker *worker;

spin_lock(&last_pool->lock);
spin_lock(&last_pool->lock);

worker = find_worker_executing_work(last_pool, work);
worker = find_worker_executing_work(last_pool, work);

if (worker && worker->current_pwq->wq == wq) {
pwq = per_cpu_ptr(wq->cpu_pwqs, last_pool->cpu);
} else {
/* meh... not running there, queue here */
spin_unlock(&last_pool->lock);
spin_lock(&pwq->pool->lock);
}
if (worker && worker->current_pwq->wq == wq) {
pwq = worker->current_pwq;
} else {
/* meh... not running there, queue here */
spin_unlock(&last_pool->lock);
spin_lock(&pwq->pool->lock);
}
} else {
pwq = first_pwq(wq);
spin_lock(&pwq->pool->lock);
}

Expand Down

0 comments on commit f1e1d02

Please sign in to comment.