Skip to content

Commit

Permalink
ext4: fix hot spins in mballoc after err_freebuddy and err_freemeta
Browse files Browse the repository at this point in the history
In ext4_mb_init_backend() 'i' is of type ext4_group_t. Since unsigned, i
>= 0 is always true, so fix hot spins after err_freebuddy: and -meta:
and prevent decrements when zero.

Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
Signed-off-by: Mingming Cao <cmm@us.ibm.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
  • Loading branch information
Roel Kluin authored and Theodore Ts'o committed Apr 30, 2008
1 parent f8a87d8 commit f1fa334
Showing 1 changed file with 3 additions and 5 deletions.
8 changes: 3 additions & 5 deletions fs/ext4/mballoc.c
Original file line number Diff line number Diff line change
Expand Up @@ -2272,13 +2272,13 @@ static int ext4_mb_init_backend(struct super_block *sb)
meta_group_info[j] = kzalloc(len, GFP_KERNEL);
if (meta_group_info[j] == NULL) {
printk(KERN_ERR "EXT4-fs: can't allocate buddy mem\n");
i--;
goto err_freebuddy;
}
desc = ext4_get_group_desc(sb, i, NULL);
if (desc == NULL) {
printk(KERN_ERR
"EXT4-fs: can't read descriptor %lu\n", i);
i++;
goto err_freebuddy;
}
memset(meta_group_info[j], 0, len);
Expand Down Expand Up @@ -2318,13 +2318,11 @@ static int ext4_mb_init_backend(struct super_block *sb)
return 0;

err_freebuddy:
while (i >= 0) {
while (i-- > 0)
kfree(ext4_get_group_info(sb, i));
i--;
}
i = num_meta_group_infos;
err_freemeta:
while (--i >= 0)
while (i-- > 0)
kfree(sbi->s_group_info[i]);
iput(sbi->s_buddy_cache);
err_freesgi:
Expand Down

0 comments on commit f1fa334

Please sign in to comment.