Skip to content

Commit

Permalink
include/asm/ptrace.h userspace headers cleanup
Browse files Browse the repository at this point in the history
This patch contains the following cleanups for the asm/ptrace.h
userspace headers:

- include/asm-generic/Kbuild.asm already lists ptrace.h, remove
  the superfluous listings in the Kbuild files of the following
  architectures:
  - cris
  - frv
  - powerpc
  - x86
- don't expose function prototypes and macros to userspace:
  - arm
  - blackfin
  - cris
  - mn10300
  - parisc
- remove #ifdef CONFIG_'s around #define's:
  - blackfin
  - m68knommu
- sh: AFAIK __SH5__ should work in both kernel and userspace,
      no need to leak CONFIG_SUPERH64 to userspace
- xtensa: cosmetical change to remove empty
            #ifndef __ASSEMBLY__ #else #endif
          from the userspace headers

Not changed by this patch is the fact that the following architectures
have a different struct pt_regs depending on CONFIG_ variables:
- h8300
- m68knommu
- mips

This does not work in userspace.

Signed-off-by: Adrian Bunk <bunk@kernel.org>
Cc: <linux-arch@vger.kernel.org>
Cc: Roland McGrath <roland@redhat.com>
Cc: Oleg Nesterov <oleg@tv-sign.ru>
Acked-by: Greg Ungerer <gerg@uclinux.org>
Acked-by: Paul Mundt <lethal@linux-sh.org>
Acked-by: Grant Grundler <grundler@parisc-linux.org>
Acked-by: Jesper Nilsson <jesper.nilsson@axis.com>
Acked-by: Chris Zankel <chris@zankel.net>
Acked-by: David Howells <dhowells@redhat.com>
Acked-by: Paul Mackerras <paulus@samba.org>
Acked-by: Russell King <rmk+kernel@arm.linux.org.uk>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Adrian Bunk authored and Linus Torvalds committed Jul 25, 2008
1 parent bc64efd commit f22ab81
Show file tree
Hide file tree
Showing 15 changed files with 32 additions and 23 deletions.
6 changes: 2 additions & 4 deletions include/asm-arm/ptrace.h
Original file line number Diff line number Diff line change
Expand Up @@ -139,8 +139,6 @@ static inline int valid_user_regs(struct pt_regs *regs)
return 0;
}

#endif /* __KERNEL__ */

#define pc_pointer(v) \
((v) & ~PCMASK)

Expand All @@ -153,10 +151,10 @@ extern unsigned long profile_pc(struct pt_regs *regs);
#define profile_pc(regs) instruction_pointer(regs)
#endif

#ifdef __KERNEL__
#define predicate(x) ((x) & 0xf0000000)
#define PREDICATE_ALWAYS 0xe0000000
#endif

#endif /* __KERNEL__ */

#endif /* __ASSEMBLY__ */

Expand Down
6 changes: 4 additions & 2 deletions include/asm-blackfin/ptrace.h
Original file line number Diff line number Diff line change
Expand Up @@ -83,21 +83,23 @@ struct pt_regs {
#define PTRACE_GETREGS 12
#define PTRACE_SETREGS 13 /* ptrace signal */

#ifdef CONFIG_BINFMT_ELF_FDPIC
#define PTRACE_GETFDPIC 31
#define PTRACE_GETFDPIC_EXEC 0
#define PTRACE_GETFDPIC_INTERP 1
#endif

#define PS_S (0x0002)

#ifdef __KERNEL__

/* user_mode returns true if only one bit is set in IPEND, other than the
master interrupt enable. */
#define user_mode(regs) (!(((regs)->ipend & ~0x10) & (((regs)->ipend & ~0x10) - 1)))
#define instruction_pointer(regs) ((regs)->pc)
#define profile_pc(regs) instruction_pointer(regs)
extern void show_regs(struct pt_regs *);

#endif /* __KERNEL__ */

#endif /* __ASSEMBLY__ */

/*
Expand Down
1 change: 0 additions & 1 deletion include/asm-cris/arch-v10/Kbuild
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
header-y += ptrace.h
header-y += user.h
header-y += svinto.h
header-y += sv_addr_ag.h
Expand Down
4 changes: 4 additions & 0 deletions include/asm-cris/arch-v10/ptrace.h
Original file line number Diff line number Diff line change
Expand Up @@ -106,10 +106,14 @@ struct switch_stack {
unsigned long return_ip; /* ip that _resume will return to */
};

#ifdef __KERNEL__

/* bit 8 is user-mode flag */
#define user_mode(regs) (((regs)->dccr & 0x100) != 0)
#define instruction_pointer(regs) ((regs)->irp)
#define profile_pc(regs) instruction_pointer(regs)
extern void show_regs(struct pt_regs *);

#endif /* __KERNEL__ */

#endif
1 change: 0 additions & 1 deletion include/asm-cris/arch-v32/Kbuild
Original file line number Diff line number Diff line change
@@ -1,3 +1,2 @@
header-y += ptrace.h
header-y += user.h
header-y += cryptocop.h
4 changes: 4 additions & 0 deletions include/asm-cris/arch-v32/ptrace.h
Original file line number Diff line number Diff line change
Expand Up @@ -106,9 +106,13 @@ struct switch_stack {
unsigned long return_ip; /* ip that _resume will return to */
};

#ifdef __KERNEL__

#define user_mode(regs) (((regs)->ccs & (1 << (U_CCS_BITNR + CCS_SHIFT))) != 0)
#define instruction_pointer(regs) ((regs)->erp)
extern void show_regs(struct pt_regs *);
#define profile_pc(regs) instruction_pointer(regs)

#endif /* __KERNEL__ */

#endif
4 changes: 3 additions & 1 deletion include/asm-cris/ptrace.h
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,13 @@
#include <asm/arch/ptrace.h>

#ifdef __KERNEL__

/* Arbitrarily choose the same ptrace numbers as used by the Sparc code. */
#define PTRACE_GETREGS 12
#define PTRACE_SETREGS 13
#endif

#define profile_pc(regs) instruction_pointer(regs)

#endif /* __KERNEL__ */

#endif /* _CRIS_PTRACE_H */
1 change: 0 additions & 1 deletion include/asm-frv/Kbuild
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,3 @@ include include/asm-generic/Kbuild.asm
header-y += registers.h

unifdef-y += termios.h
unifdef-y += ptrace.h
2 changes: 0 additions & 2 deletions include/asm-m68knommu/ptrace.h
Original file line number Diff line number Diff line change
Expand Up @@ -68,10 +68,8 @@ struct switch_stack {
/* Arbitrarily choose the same ptrace numbers as used by the Sparc code. */
#define PTRACE_GETREGS 12
#define PTRACE_SETREGS 13
#ifdef CONFIG_FPU
#define PTRACE_GETFPREGS 14
#define PTRACE_SETFPREGS 15
#endif

#ifdef __KERNEL__

Expand Down
8 changes: 6 additions & 2 deletions include/asm-mn10300/ptrace.h
Original file line number Diff line number Diff line change
Expand Up @@ -88,12 +88,16 @@ extern struct pt_regs *__frame; /* current frame pointer */
/* options set using PTRACE_SETOPTIONS */
#define PTRACE_O_TRACESYSGOOD 0x00000001

#if defined(__KERNEL__) && !defined(__ASSEMBLY__)
#if defined(__KERNEL__)

#if !defined(__ASSEMBLY__)
#define user_mode(regs) (((regs)->epsw & EPSW_nSL) == EPSW_nSL)
#define instruction_pointer(regs) ((regs)->pc)
extern void show_regs(struct pt_regs *);
#endif
#endif /* !__ASSEMBLY */

#define profile_pc(regs) ((regs)->pc)

#endif /* __KERNEL__ */

#endif /* _ASM_PTRACE_H */
4 changes: 3 additions & 1 deletion include/asm-parisc/ptrace.h
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ struct pt_regs {
unsigned long ipsw; /* CR22 */
};

#define task_regs(task) ((struct pt_regs *) ((char *)(task) + TASK_REGS))
/*
* The numbers chosen here are somewhat arbitrary but absolutely MUST
* not overlap with any of the number assigned in <linux/ptrace.h>.
Expand All @@ -43,8 +42,11 @@ struct pt_regs {
* since we have taken branch traps too)
*/
#define PTRACE_SINGLEBLOCK 12 /* resume execution until next branch */

#ifdef __KERNEL__

#define task_regs(task) ((struct pt_regs *) ((char *)(task) + TASK_REGS))

/* XXX should we use iaoq[1] or iaoq[0] ? */
#define user_mode(regs) (((regs)->iaoq[0] & 3) ? 1 : 0)
#define user_space(regs) (((regs)->iasq[1] != 0) ? 1 : 0)
Expand Down
1 change: 0 additions & 1 deletion include/asm-powerpc/Kbuild
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ unifdef-y += elf.h
unifdef-y += nvram.h
unifdef-y += param.h
unifdef-y += posix_types.h
unifdef-y += ptrace.h
unifdef-y += seccomp.h
unifdef-y += signal.h
unifdef-y += spu_info.h
Expand Down
2 changes: 1 addition & 1 deletion include/asm-sh/ptrace.h
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
* Copyright (C) 1999, 2000 Niibe Yutaka
*
*/
#if defined(__SH5__) || defined(CONFIG_SUPERH64)
#if defined(__SH5__)
struct pt_regs {
unsigned long long pc;
unsigned long long sr;
Expand Down
1 change: 0 additions & 1 deletion include/asm-x86/Kbuild
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ unifdef-y += msr.h
unifdef-y += mtrr.h
unifdef-y += posix_types_32.h
unifdef-y += posix_types_64.h
unifdef-y += ptrace.h
unifdef-y += unistd_32.h
unifdef-y += unistd_64.h
unifdef-y += vm86.h
Expand Down
10 changes: 5 additions & 5 deletions include/asm-xtensa/ptrace.h
Original file line number Diff line number Diff line change
Expand Up @@ -73,10 +73,10 @@
#define PTRACE_GETXTREGS 18
#define PTRACE_SETXTREGS 19

#ifndef __ASSEMBLY__

#ifdef __KERNEL__

#ifndef __ASSEMBLY__

/*
* This struct defines the way the registers are stored on the
* kernel stack during a system call or other kernel entry.
Expand Down Expand Up @@ -122,14 +122,14 @@ extern void show_regs(struct pt_regs *);
# ifndef CONFIG_SMP
# define profile_pc(regs) instruction_pointer(regs)
# endif
#endif /* __KERNEL__ */

#else /* __ASSEMBLY__ */

#ifdef __KERNEL__
# include <asm/asm-offsets.h>
#define PT_REGS_OFFSET (KERNEL_STACK_SIZE - PT_USER_SIZE)
#endif

#endif /* !__ASSEMBLY__ */

#endif /* __KERNEL__ */

#endif /* _XTENSA_PTRACE_H */

0 comments on commit f22ab81

Please sign in to comment.