Skip to content

Commit

Permalink
Staging: hv: remove function pointer typedefs from StorVscApi.h
Browse files Browse the repository at this point in the history
function pointer typedefs are allowed in the kernel, but only if they
make sense, which they really do not here, as they are not passed around
with any kind of frequency.  So just spell them all out, it makes the
code smaller and easier to understand overall.

Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
Greg Kroah-Hartman committed Sep 15, 2009
1 parent 211ccd6 commit f25c749
Showing 1 changed file with 5 additions and 12 deletions.
17 changes: 5 additions & 12 deletions drivers/staging/hv/StorVscApi.h
Original file line number Diff line number Diff line change
Expand Up @@ -45,14 +45,6 @@

struct hv_storvsc_request;

/* Data types */
typedef int (*PFN_ON_IO_REQUEST)(struct hv_device *Device,
struct hv_storvsc_request *Request);
typedef void (*PFN_ON_IO_REQUEST_COMPLTN)(struct hv_storvsc_request *Request);

typedef int (*PFN_ON_HOST_RESET)(struct hv_device *Device);
typedef void (*PFN_ON_HOST_RESCAN)(struct hv_device *Device);

/* Matches Windows-end */
enum storvsc_request_type{
WRITE_TYPE,
Expand All @@ -76,7 +68,7 @@ struct hv_storvsc_request {

void *Context;

PFN_ON_IO_REQUEST_COMPLTN OnIOCompletion;
void (*OnIOCompletion)(struct hv_storvsc_request *Request);

/* This points to the memory after DataBuffer */
void *Extension;
Expand All @@ -100,11 +92,12 @@ struct storvsc_driver_object {
u32 MaxOutstandingRequestsPerChannel;

/* Set by the caller to allow us to re-enumerate the bus on the host */
PFN_ON_HOST_RESCAN OnHostRescan;
void (*OnHostRescan)(struct hv_device *Device);

/* Specific to this driver */
PFN_ON_IO_REQUEST OnIORequest;
PFN_ON_HOST_RESET OnHostReset;
int (*OnIORequest)(struct hv_device *Device,
struct hv_storvsc_request *Request);
int (*OnHostReset)(struct hv_device *Device);
};

struct storvsc_device_info {
Expand Down

0 comments on commit f25c749

Please sign in to comment.