Skip to content

Commit

Permalink
Staging: SLICOSS: Call pci_release_regions at driver exit
Browse files Browse the repository at this point in the history
slic_entry_probe() calls pci_request_regions() but there's no matching
pci_release_regions() at driver's exit or if slic_entry_probe() fails.

Signed-off-by: Lior Dotan <liodot@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
Lior Dotan authored and Greg Kroah-Hartman committed Oct 10, 2008
1 parent 68cf95f commit f25fda7
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions drivers/staging/slicoss/slicoss.c
Original file line number Diff line number Diff line change
Expand Up @@ -520,6 +520,7 @@ static int __devinit slic_entry_probe(struct pci_dev *pcidev,
release_mem_region(mmio_start, mmio_len);

err_out_exit_slic_probe:
pci_release_regions(pcidev);
DBG_ERROR("%s EXIT jiffies[%lx] cpu %d\n", __func__, jiffies,
smp_processor_id());

Expand Down Expand Up @@ -649,6 +650,7 @@ static void __devexit slic_entry_remove(struct pci_dev *pcidev)
}
DBG_MSG("slicoss: %s deallocate device\n", __func__);
kfree(dev);
pci_release_regions(pcidev);
DBG_MSG("slicoss: %s EXIT\n", __func__);
}

Expand Down

0 comments on commit f25fda7

Please sign in to comment.