Skip to content

Commit

Permalink
ath10k: prevent hif_stop being called twice
Browse files Browse the repository at this point in the history
Recently there was a bug discovered that involved
hif_stop() being called twice that ended up with a
double free_irq() call but it only manifested with
multiple MSI interrupts mapping.

Catch this kind of a problem early in driver
regardless of interrupt mapping.

Signed-off-by: Michal Kazior <michal.kazior@tieto.com>
Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>
  • Loading branch information
Michal Kazior authored and Kalle Valo committed May 23, 2014
1 parent 95bf21f commit f2708be
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions drivers/net/wireless/ath/ath10k/pci.c
Original file line number Diff line number Diff line change
Expand Up @@ -1272,6 +1272,9 @@ static void ath10k_pci_hif_stop(struct ath10k *ar)

ath10k_dbg(ATH10K_DBG_BOOT, "boot hif stop\n");

if (WARN_ON(!ar_pci->started))
return;

ret = ath10k_ce_disable_interrupts(ar);
if (ret)
ath10k_warn("failed to disable CE interrupts: %d\n", ret);
Expand Down

0 comments on commit f2708be

Please sign in to comment.