Skip to content

Commit

Permalink
[PATCH] iseries_veth: Don't send packets to LPARs which aren't up
Browse files Browse the repository at this point in the history
Hi Andrew, Jeff,

The iseries_veth driver has a logic bug which means it will erroneously
send packets to LPARs for which we don't have a connection.

This usually isn't a big problem because the Hypervisor call fails
gracefully and we return, but if packets are TX'ed during the negotiation
of the connection bad things might happen.

Regardless, the right thing is to bail early if we know there's no
connection.

Signed-off-by: Michael Ellerman <michael@ellerman.id.au>
  • Loading branch information
Michael Ellerman authored and Jeff Garzik committed May 15, 2005
1 parent 88d7bd8 commit f27eff1
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/net/iseries_veth.c
Original file line number Diff line number Diff line change
Expand Up @@ -924,7 +924,7 @@ static int veth_transmit_to_one(struct sk_buff *skb, HvLpIndex rlp,

spin_lock_irqsave(&cnx->lock, flags);

if (! cnx->state & VETH_STATE_READY)
if (! (cnx->state & VETH_STATE_READY))
goto drop;

if ((skb->len - 14) > VETH_MAX_MTU)
Expand Down

0 comments on commit f27eff1

Please sign in to comment.