Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 176496
b: refs/heads/master
c: c244bb5
h: refs/heads/master
v: v3
  • Loading branch information
Vivek Goyal authored and Jens Axboe committed Dec 9, 2009
1 parent c09d1da commit f2c76ac
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 10 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: b9d8f4c73b1af4cfd53f819bf84c2bce31232275
refs/heads/master: c244bb50a9baa2ec47a458bbafb36b5e559ed5fa
17 changes: 8 additions & 9 deletions trunk/block/cfq-iosched.c
Original file line number Diff line number Diff line change
Expand Up @@ -319,7 +319,6 @@ enum cfqq_state_flags {
CFQ_CFQQ_FLAG_coop, /* cfqq is shared */
CFQ_CFQQ_FLAG_deep, /* sync cfqq experienced large depth */
CFQ_CFQQ_FLAG_wait_busy, /* Waiting for next request */
CFQ_CFQQ_FLAG_wait_busy_done, /* Got new request. Expire the queue */
};

#define CFQ_CFQQ_FNS(name) \
Expand Down Expand Up @@ -348,7 +347,6 @@ CFQ_CFQQ_FNS(sync);
CFQ_CFQQ_FNS(coop);
CFQ_CFQQ_FNS(deep);
CFQ_CFQQ_FNS(wait_busy);
CFQ_CFQQ_FNS(wait_busy_done);
#undef CFQ_CFQQ_FNS

#ifdef CONFIG_DEBUG_CFQ_IOSCHED
Expand Down Expand Up @@ -1574,7 +1572,6 @@ __cfq_slice_expired(struct cfq_data *cfqd, struct cfq_queue *cfqq,

cfq_clear_cfqq_wait_request(cfqq);
cfq_clear_cfqq_wait_busy(cfqq);
cfq_clear_cfqq_wait_busy_done(cfqq);

/*
* store what was left of this slice, if the queue idled/timed out
Expand Down Expand Up @@ -2134,11 +2131,17 @@ static struct cfq_queue *cfq_select_queue(struct cfq_data *cfqd)

if (!cfqd->rq_queued)
return NULL;

/*
* We were waiting for group to get backlogged. Expire the queue
*/
if (cfq_cfqq_wait_busy(cfqq) && !RB_EMPTY_ROOT(&cfqq->sort_list))
goto expire;

/*
* The active queue has run out of time, expire it and select new.
*/
if ((cfq_slice_used(cfqq) || cfq_cfqq_wait_busy_done(cfqq))
&& !cfq_cfqq_must_dispatch(cfqq))
if (cfq_slice_used(cfqq) && !cfq_cfqq_must_dispatch(cfqq))
goto expire;

/*
Expand Down Expand Up @@ -3171,10 +3174,6 @@ cfq_rq_enqueued(struct cfq_data *cfqd, struct cfq_queue *cfqq,
cfqq->last_request_pos = blk_rq_pos(rq) + blk_rq_sectors(rq);

if (cfqq == cfqd->active_queue) {
if (cfq_cfqq_wait_busy(cfqq)) {
cfq_clear_cfqq_wait_busy(cfqq);
cfq_mark_cfqq_wait_busy_done(cfqq);
}
/*
* Remember that we saw a request from this process, but
* don't start queuing just yet. Otherwise we risk seeing lots
Expand Down

0 comments on commit f2c76ac

Please sign in to comment.