Skip to content

Commit

Permalink
x86: simplify set_bitmap in ioport_32.c
Browse files Browse the repository at this point in the history
Simplify set_bitmap(). This is not in a hotpath and we really can use the
straight forward loop through those bits. A similar implementation is used
in the 64 bit code as well.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
  • Loading branch information
Thomas Gleixner authored and Ingo Molnar committed Jan 30, 2008
1 parent 3ebc51d commit f2f5817
Showing 1 changed file with 6 additions and 26 deletions.
32 changes: 6 additions & 26 deletions arch/x86/kernel/ioport_32.c
Original file line number Diff line number Diff line change
Expand Up @@ -16,36 +16,16 @@
#include <linux/syscalls.h>

/* Set EXTENT bits starting at BASE in BITMAP to value TURN_ON. */
static void set_bitmap(unsigned long *bitmap, unsigned int base, unsigned int extent, int new_value)
static void set_bitmap(unsigned long *bitmap, unsigned int base,
unsigned int extent, int new_value)
{
unsigned long mask;
unsigned long *bitmap_base = bitmap + (base / BITS_PER_LONG);
unsigned int low_index = base & (BITS_PER_LONG-1);
int length = low_index + extent;

if (low_index != 0) {
mask = (~0UL << low_index);
if (length < BITS_PER_LONG)
mask &= ~(~0UL << length);
if (new_value)
*bitmap_base++ |= mask;
else
*bitmap_base++ &= ~mask;
length -= BITS_PER_LONG;
}

mask = (new_value ? ~0UL : 0UL);
while (length >= BITS_PER_LONG) {
*bitmap_base++ = mask;
length -= BITS_PER_LONG;
}
unsigned int i;

if (length > 0) {
mask = ~(~0UL << length);
for (i = base; i < base + extent; i++) {
if (new_value)
*bitmap_base++ |= mask;
__set_bit(i, bitmap);
else
*bitmap_base++ &= ~mask;
__clear_bit(i, bitmap);
}
}

Expand Down

0 comments on commit f2f5817

Please sign in to comment.