Skip to content

Commit

Permalink
smc911x: Fix external PHY detection
Browse files Browse the repository at this point in the history
If an external PHY is found the driver falls through to the default
case in the switch and overwrites the PHY ID. Add the missing break.

Signed-off-by: Guennadi Liakhovetski <lg@denx.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Guennadi Liakhovetski authored and David S. Miller committed Oct 11, 2008
1 parent 20501a6 commit f3073ac
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions drivers/net/smc911x.c
Original file line number Diff line number Diff line change
Expand Up @@ -722,6 +722,9 @@ static void smc911x_phy_detect(struct net_device *dev)
break;
}
}
if (phyaddr < 32)
/* Found an external PHY */
break;
}
default:
/* Internal media only */
Expand Down

0 comments on commit f3073ac

Please sign in to comment.