Skip to content

Commit

Permalink
smsc911x: timeout reaches -1
Browse files Browse the repository at this point in the history
With a postfix decrement the timeout will reach -1 rather than 0,
so the warning will not be issued.

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Acked-by: Steve Glendinning <steve.glendinning@smsc.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Roel Kluin authored and David S. Miller committed Jan 30, 2009
1 parent 1609559 commit f307dbd
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/net/smsc911x.c
Original file line number Diff line number Diff line change
Expand Up @@ -953,7 +953,7 @@ smsc911x_rx_fastforward(struct smsc911x_data *pdata, unsigned int pktbytes)
do {
udelay(1);
val = smsc911x_reg_read(pdata, RX_DP_CTRL);
} while (timeout-- && (val & RX_DP_CTRL_RX_FFWD_));
} while (--timeout && (val & RX_DP_CTRL_RX_FFWD_));

if (unlikely(timeout == 0))
SMSC_WARNING(HW, "Timed out waiting for "
Expand Down

0 comments on commit f307dbd

Please sign in to comment.